Skip to content

memcg: prevent -ENOMEM in pre_destroy()

KAMEZAWA Hiroyuki cgroups linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 21 repliesIn review
  2. v2 RFC4 of 7 patches 17 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6memcg: fix error code in hugetlb_force_memcg_empty()mm/hugetlb.c+4 -16 replies
2/6add res_counter_uncharge_until()Documentation/cgroups/resource_counter.txt include/linux/res_counter.h kernel/res_counter.c+19 -26 replies
3/6memcg: use res_counter_uncharge_until in move_parent()mm/memcontrol.c+42 -210 replies
4/6memcg: move charges to root cgroup if use_hierarchy=0.Documentation/cgroups/memory.txt mm/memcontrol.c+25 -372 replies
5/6memcg: don't uncharge in mem_cgroup_move_accountmm/memcontrol.c+6 -140 replies
6/6remove __must_check for res_counter_charge_nofail()include/linux/res_counter.h+1 -12 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchAneesh Kumar K.VTejun Heo
1/6R-b R-b
2/6A-b
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3][0/6] memcg: prevent -ENOMEM in pre_destroy()

Hi, here is v3 based on memcg-devel tree.
git://github.com/mstsxfx/memcg-devel.git

This patch series is for avoiding -ENOMEM at calling pre_destroy() which is called at rmdir(). After this patch, charges will be moved to root (if use_hierarchy==0) or parent (if use_hierarchy==1), and we'll not see -ENOMEM in rmdir() of cgroup.

v2 included some other patches than ones for handling -ENOMEM problem, but I divided it. I'd like to post others in different series, later. No logical changes in general, maybe v3 is cleaner than v2.

0001 ....fix error code in memcg-hugetlb
0002 ....add res_counter_uncharge_until
0003 ....use res_counter_uncharge_until in memcg
0004 ....move charges to root is use_hierarchy==0
0005 ....cleanup for mem_cgroup_move_account()
0006 ....remove warning of res_counter_uncharge_nofail (from Costa's slub accounting series).

Regards,
-Kame