Skip to content

continued messenger-related changes

Alex Elder ceph-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 11 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 11 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchAlex ElderSage Weil
SeriesR-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] continued messenger-related changes

This is a series of 11 related patches but I've grouped them into smaller sub-sets as follows. A few of these were posted previously but their changes--if any--were merely related to adjustments to account for other patches inserted before them in the series. Two of them are being submitted on behalf of Sage Weil.

These patches can also be viewed here:
https://github.com/ceph/ceph-client/commits/wip-messenger-review

-Alex

[PATCH] libceph: osd_client: don't drop reply reference too early
This fixes a potential bug found by inspection.

[PATCH] libceph: use con get/put ops from osd_client
This fixes a possibly serious problem with reference counting that Sage found while reviewing my last series of patches.

[PATCH 1/2] libceph: embed ceph connection structure in mon_client [PATCH 2/2] libceph: drop connection refcounting for mon_client
These two rearrange how the ceph connection is represented in a mon_client structure, and make the referencing counting methods no-ops.

[PATCH 1/2] libceph: init monitor connection when opening [PATCH 2/2] libceph: fully initialize connection in con_init()
This finishes a small sub-series from before that did not get fully committed. It unifies the way ceph connections are initialized so that ceph connection fields are manipulated by the messenger code, not the caller.

[PATCH] libceph: tweak ceph_alloc_msg()
This is a standalone cleanup that aims to make the real purpose of this function a bit more obvious.

[PATCH 1/4] libceph: have messages point to their connection [PATCH 2/4] libceph: have messages take a connection reference [PATCH 3/4] libceph: make ceph_con_revoke() a msg operation [PATCH 4/4] libceph: make ceph_con_revoke_message() a msg op
These four patches make every message maintain a reference to the connection it is associated with. Having this reference allows the revoke routines to be called with a message alone rather than having to supply a connection pointer as well.