Skip to content

common/lcd cleanup

Nikita Kiryanov u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 4 patches 0 repliesNew
  2. v3 posting 1/24 patches 0 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 of 7 patches0 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [U-Boot] [PATCH V3 0/4] common/lcd cleanup

Gentle ping.

Quoted 29 lines · Nikita Kiryanov

This patch series attempts to simplify #ifdef complexity in common/lcd.c.

It was compile tested on Arm and PowerPC using MAKEALL

Changes in V3:
- Rebased on latest u-boot-video
- Removed volatile qualifiers in patch 3 since the use of volatile is discouraged and it looks like it is safe to remove them.

Changes in V2:
- Rebased on u-boot-video
- patches 2 and 3 of original patchset dropped because I'm not sure what to do about them
- simplify lcd_logo: used bitmap_display() to further simplify code
- simplify lcd_display_bitmap: fixed pointer increment error
- simplify lcd_display_bitmap: change to simplify lcd_logo breaks MCC200 board because it does not #define CONFIG_CMD_BMP. Added a local implementation of bitmap_display().

Nikita Kiryanov (4):
common lcd: simplify lcd_logo
common lcd: simplify lcd_display
common lcd: simplify core functions
common lcd: simplify lcd_display_bitmap

  board/mcc200/lcd.c |   20 +++++++
  common/lcd.c       |  145 +++++++++++++++++++++++++++-------------------------
  2 files changed, 96 insertions(+), 69 deletions(-)