Skip to content

RFC memory-hotplug : hot-remove physical memory

Yasuaki Ishimatsu linux-acpi linux-mm linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 RFC Latest13 patches 17 repliesIn review
  2. v3 RFC13 patches 37 repliesSuperseded
  3. v2 RFC13 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC12 patches24 repliesSuperseded

Changes in v4 from the cover letter

* remove "memory-hotplug : unify argument of firmware_map_add_early/hotplug" from the patch series, since the patch is a bugfix. It is being disccussed on other thread. But for testing the patch series, the patch is needed. So I added the patch as [PATCH 0/13].

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13memory-hotplug : rename remove_memory to offline_memorydrivers/acpi/acpi_memhotplug.c drivers/base/memory.c include/linux/memory_hotplug.h +1 more+7 -72 replies
2/13memory-hotplug : add physical memory hotplug code to acpi_memory_device_removedrivers/acpi/acpi_memhotplug.c drivers/base/memory.c include/linux/memory.h +2 more+97 -12 replies
3/13memory-hotplug : check whether memory is present or notinclude/linux/mmzone.h mm/memory_hotplug.c+34 -03 replies
4/13memory-hotplug : remove /sys/firmware/memmap/X sysfsdrivers/firmware/memmap.c include/linux/firmware-map.h mm/memory_hotplug.c+90 -32 replies
5/13memory-hotplug : does not release memory region in PAGES_PER_SECTION chunksarch/powerpc/platforms/pseries/hotplug-memory.c mm/memory_hotplug.c+11 -60 replies
6/13memory-hotplug : add memory_block_releasedrivers/base/memory.c+10 -10 replies
7/13memory-hotplug : remove_memory calls __remove_pagesarch/powerpc/platforms/pseries/hotplug-memory.c include/linux/memory_hotplug.h mm/memory_hotplug.c+14 -132 replies
8/13memory-hotplug : check page type in get_page_bootmemmm/memory_hotplug.c+11 -40 replies
9/13memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmapinclude/linux/memory_hotplug.h mm/memory_hotplug.c+6 -110 replies
11/13memory-hotplug : free memmap of sparse-vmemmaparch/x86/mm/init_64.c include/linux/mm.h mm/memory_hotplug.c +1 more+128 -195 replies
11/13memory-hotplug : free memmap of sparse-vmemmaparch/x86/mm/init_64.c include/linux/mm.h mm/memory_hotplug.c +1 more+128 -170 replies
12/13memory-hotplug : add node_device_releasedrivers/base/node.c+7 -01 reply
13/13memory-hotplug : remove sysfs file of nodemm/memory_hotplug.c+5 -00 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDave Hansen
SeriesR-b
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
11/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [RFC PATCH v4 0/13] memory-hotplug : hot-remove physical memory

This patch series aims to support physical memory hot-remove.

[RFC PATCH v4 1/13] memory-hotplug : rename remove_memory to offline_memory
[RFC PATCH v4 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove [RFC PATCH v4 3/13] memory-hotplug : check whether memory is present or not
[RFC PATCH v4 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs
[RFC PATCH v4 5/13] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks [RFC PATCH v4 6/13] memory-hotplug : add memory_block_release
[RFC PATCH v4 7/13] memory-hotplug : remove_memory calls __remove_pages
[RFC PATCH v4 8/13] memory-hotplug : check page type in get_page_bootmem
[RFC PATCH v4 9/13] memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for
sparse-vmemmap4
[RFC PATCH v4 10/13] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap [RFC PATCH v4 11/13] memory-hotplug : free memmap of sparse-vmemmap
[RFC PATCH v4 12/13] memory-hotplug : add node_device_release
[RFC PATCH v4 13/13] memory-hotplug : remove sysfs file of node

Even if you apply these patches, you cannot remove the physical memory completely since these patches are still under development. But other components can be removed. I want you to cooperate to improve the physical memory hot-remove. So please review these patches and give your comment/idea.

The patches can free/remove following things:

- acpi_memory_info : [RFC PATCH 2/13]
- /sys/firmware/memmap/X/{end, start, type} : [RFC PATCH 4/13]

  - iomem_resource                            : [RFC PATCH 5/13]
  - mem_section and related sysfs files       : [RFC PATCH 6-11/13]
  - node and related sysfs files              : [RFC PATCH 12-13/13]

The patches cannot do following things yet:

- page table of removed memory

If you find lack of function for physical memory hot-remove, please let me know.

change log of v4:
* remove "memory-hotplug : unify argument of firmware_map_add_early/hotplug" from the patch series, since the patch is a bugfix. It is being disccussed on other thread. But for testing the patch series, the patch is needed. So I added the patch as [PATCH 0/13].

[RFC PATCH v4 2/13]
* check memory is online or not at remove_memory()
* add memory_add_physaddr_to_nid() to acpi_memory_device_remove() for getting node id

[RFC PATCH v4 3/13]
* create new patch : check memory is online or not at online_pages()

[RFC PATCH v4 4/13]
* add __ref section to remove_memory()
* call firmware_map_remove_entry() before remove_sysfs_fw_map_entry()

[RFC PATCH v4 11/13]
* rewrite register_page_bootmem_memmap() for removing page used as PT/PMD

change log of v3:
* rebase to 3.5.0-rc6

[RFC PATCH v2 2/13]
* remove extra kobject_put()

* The patch was commented by Wen. Wen's comment is "acpi_memory_device_remove() should ignore a return value of remove_memory() since caller does not care the return value". But I did not change it since I think caller should care the return value. And I am trying to fix it as follow:

https://lkml.org/lkml/2012/7/5/624

[RFC PATCH v2 4/13]
* remove a firmware_memmap_entry allocated by kzmalloc()

change log of v2:
[RFC PATCH v2 2/13]
* check whether memory block is offline or not before calling offline_memory()
* check whether section is valid or not in is_memblk_offline()
* call kobject_put() for each memory_block in is_memblk_offline()

[RFC PATCH v2 3/13]
* unify the end argument of firmware_map_add_early/hotplug

[RFC PATCH v2 4/13]
* add release_firmware_map_entry() for freeing firmware_map_entry

[RFC PATCH v2 6/13]
* add release_memory_block() for freeing memory_block

[RFC PATCH v2 11/13]
* fix wrong arguments of free_pages()

---
 arch/powerpc/platforms/pseries/hotplug-memory.c |   16 +-
 arch/x86/mm/init_64.c                           |  144 ++++++++++++++++++++++++
 drivers/acpi/acpi_memhotplug.c                  |   28 ++++
 drivers/base/memory.c                           |   54 ++++++++-
 drivers/base/node.c                             |    7 +
 drivers/firmware/memmap.c                       |   78 ++++++++++++-
 include/linux/firmware-map.h                    |    6 +
 include/linux/memory.h                          |    5 
 include/linux/memory_hotplug.h                  |   17 --
 include/linux/mm.h                              |    5 
 mm/memory_hotplug.c                             |   98 ++++++++++++----
 mm/sparse.c                                     |    5 
 12 files changed, 414 insertions(+), 49 deletions(-)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>