rbd: updates and enhancements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest16 patches 37 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | libceph: fix off-by-one bug in ceph_encode_filepath()include/ | +0 | 2 replies | |
| 2/16 | rbd: drop a useless local variabledrivers/ | +0 | 2 replies | |
| 3/16 | libceph: define ceph_decode_string()include/ | +0 | 4 replies | |
| 4/16 | libceph: define ceph_extract_encoded_string()include/ | +0 | 10 replies | |
| 5/16 | rbd: define dup_token()drivers/ | +36 | 3 replies | |
| 6/16 | rbd: rename rbd_dev->block_namedrivers/ | +1 | 3 replies | |
| 7/16 | rbd: dynamically allocate object prefixdrivers/ | +1 | 4 replies | |
| 8/16 | rbd: don't store pool name in struct rbd_devdrivers/ | +3 | 12 replies | |
| 9/16 | rbd: dynamically allocate image header namedrivers/ | +1 | 1 reply | |
| 10/16 | rbd: dynamically allocate image namedrivers/ drivers/ | +2 | 3 replies | |
| 11/16 | rbd: dynamically allocate snapshot namedrivers/ | +1 | 1 reply | |
| 12/16 | rbd: use rbd_dev consistentlydrivers/ | +0 | 1 reply | |
| 13/16 | rbd: rename some fields in struct rbd_devdrivers/ | +3 | 2 replies | |
| 14/16 | rbd: more symbol renamesdrivers/ | +7 | 2 replies | |
| 15/16 | rbd: option symbol renamesdrivers/ | +0 | 1 reply | |
| 16/16 | rbd: kill num_reply parametersdrivers/ | +1 | 1 reply |
Reviews trailers per patch
12 of 16 patches have a Reviewed-by or Acked-by.
| Patch | Yehuda Sadeh | Josh Durgin |
|---|---|---|
| 1/16 | R-b | R-b |
| 2/16 | R-b | R-b |
| 3/16 | R-b | R-b |
| 4/16 | ||
| 5/16 | R-b | R-b |
| 6/16 | R-b | R-b |
| 7/16 | R-b | |
| 8/16 | R-b | |
| 9/16 | R-b | |
| 10/16 | R-b | |
| 11/16 | R-b | |
| 12/16 | R-b | |
| 13/16 | ||
| 14/16 | ||
| 15/16 | ||
| 16/16 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/16] rbd: updates and enhancements
The following series of patches constitute a few minor fixes and cleanups, as well as some new utility routines in the rbd code. Some of these comprise a foundation that's being used to add support for the "new" rbd image format.
We've agreed to refer to the "old" and "new" formats as format 1 and 2, respectively.
-Alex
[PATCH 01/16] libceph: fix off-by-one bug in ceph_encode_filepath()
This is a minor bug fix.
[PATCH 02/16] rbd: drop a useless local variable
This is a minor cleanup.
[PATCH 03/16] libceph: define ceph_decode_string() [PATCH 04/16] libceph: define ceph_extract_encoded_string() [PATCH 05/16] rbd: define dup_token()
Each of these defines a new utility routine. They are all going to be used in some upcoming rbd patches, but they're ready for review now.
[PATCH 06/16] rbd: rename rbd_dev->block_name
[PATCH 07/16] rbd: dynamically allocate object prefix
These update the "block_name" field of a rbd_dev structure to be named "object_prefix", which is consistent with the way the new rbd format describes it. It also removes the unnecessary fixed limit on the length of that string.
[PATCH 08/16] rbd: don't store pool name in struct rbd_dev
Since a pool name can change, this patch makes sure the rbd client code doesn't save a copy of it--relying instead on the invariant pool id. The "pool" entry has been replaced by "pool_id" in /sys/bus/rbd/<N>.
[PATCH 09/16] rbd: dynamically allocate image header name [PATCH 10/16] rbd: dynamically allocate image name [PATCH 11/16] rbd: dynamically allocate snapshot name
These three change some more fields for in-core data structures so they aren't arbitrarily limited to a fixed size.
[PATCH 12/16] rbd: use rbd_dev consistently
This makes all variables representing a struct rbd_device be named "rbd_dev".
[PATCH 13/16] rbd: rename some fields in struct rbd_dev [PATCH 14/16] rbd: more symbol renames
[PATCH 15/16] rbd: option symbol renames
These change the names of some fields and symbols so they are (hopefully) a bit more descriptive.
[PATCH 16/16] rbd: kill num_reply parameters
This eliminates an unused parameter that was defined in a number of functions.