LVM2: some code cleanups and bugfixs checked by codeDEX tools
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] LVM2: some code cleanups and bugfixs checked by codeDEX tools
Dne 11. 09. 20 v 13:07 Zdenek Kabelac napsal(a):
Quoted 19 lines
Dne 11. 09. 20 v 11:38 Wu Guanghao napsal(a):
Quoted 9 lines
When I learn the LVM2 source code and test it, I find some bugs and fix them. At the same time, static scanning tools were used to analyze the code, and several possible problems were found.
repo: https://sourceware.org/git/lvm2.git
repo link: https://sourceware.org/git/lvm2.git
branch: masterQuoted 7 lines
wuguanghao (4):
?? pvmove: check return value oftop_level_lv_name()in_set_up_pvmove_lv??lvconvert_poll: check whether lv is a snapshot type inpoll_thin_merge_progress
?? lvconvert:_lvconvert_splitsnapshotcheck if lv is snapshot type ?? fix core dump when thinpool size more than the remaining space of vg
Quoted 6 lines
Hi
Great findings - I'll check how they could be applied. In some cases you are rather fixed internal error so it's always great if some test case which show how the error can be hit is provided (like in patch 4)
Hi
So the patches are upstream - although they need some extra care:
1 ->
https://www.redhat.com/archives/lvm-devel/2020-September/msg00059.html
Added handling of lv_name
2 ->
https://www.redhat.com/archives/lvm-devel/2020-September/msg00063.html
Switched || to &&
3 ->
https://www.redhat.com/archives/lvm-devel/2020-September/msg00069.html
We are actually splitting 'cow' so lv_is_cow()
4 ->
https://www.redhat.com/archives/lvm-devel/2020-September/msg00062.html
Fixed differently by correcting evaluation of needed extents for allocation.
Once again thanks for reporting mainly the issue from patch 4.
Regards
Zdenek