Skip to content

rbd: cleanup series

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12rbd: drop extra header_rwsem initdrivers/block/rbd.c+0 -20 replies
2/12rbd: simplify __rbd_remove_all_snaps()drivers/block/rbd.c+2 -30 replies
3/12rbd: clean up a few dout() callsdrivers/block/rbd.c+1 -10 replies
4/12ceph: define snap counts as u32 everywherefs/ceph/snap.c fs/ceph/super.h include/linux/ceph/libceph.h+3 -30 replies
5/12rbd: snapc is unused in rbd_req_sync_read()drivers/block/rbd.c+1 -20 replies
6/12rbd: drop rbd_header_from_disk() gfp_flags parameterdrivers/block/rbd.c+1 -20 replies
7/12rbd: drop rbd_dev parameter in snap functionsdrivers/block/rbd.c+1 -20 replies
8/12rbd: drop rbd_req_sync_exec() "ver" parameterdrivers/block/rbd.c+0 -00 replies
9/12rbd: have __rbd_add_snap_dev() return a pointerdrivers/block/rbd.c+0 -00 replies
10/12rbd: make rbd_create_rw_ops() return a pointerdrivers/block/rbd.c+20 -160 replies
11/12rbd: always pass ops array to rbd_req_sync_op()drivers/block/rbd.c+0 -00 replies
12/12rbd: fixes in rbd_header_from_disk()drivers/block/rbd.c+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] rbd: cleanup series

This series includes a bunch of relatively small cleanups. They're grouped a bit below, but they apply together in this sequence and the later ones may have dependencies on those earlier in the series.

Summaries:
[PATCH 01/12] rbd: drop extra header_rwsem init [PATCH 02/12] rbd: simplify __rbd_remove_all_snaps() [PATCH 03/12] rbd: clean up a few dout() calls [PATCH 04/12] ceph: define snap counts as u32 everywhere
These four are very simple and straightforward cleanups.

[PATCH 05/12] rbd: snapc is unused in rbd_req_sync_read() [PATCH 06/12] rbd: drop rbd_header_from_disk() gfp_flags parameter [PATCH 07/12] rbd: drop rbd_dev parameter in snap functions [PATCH 08/12] rbd: drop rbd_req_sync_exec() "ver" parameter
These four each drop an unused argument from a function.

[PATCH 09/12] rbd: have __rbd_add_snap_dev() return a pointer [PATCH 10/12] rbd: make rbd_create_rw_ops() return a pointer
These two each change a function so it returns a pointer rather than filling in the address of a provided pointer.

[PATCH 11/12] rbd: always pass ops array to rbd_req_sync_op() [PATCH 12/12] rbd: fixes in rbd_header_from_disk()
These comprise slightly more involved refactoring of the code, but as with the rest of the patches in this series, there should be no functional difference as a result.

-Alex