RFC OMAP Cpuidle/Suspend Cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/4] OMAP Cpuidle/Suspend Cleanups
Quoted 22 lines · Tero Kristo
Quoted 7 lines · Rajendra Nayak
Hi,
Here are some CPUidle/Suspend cleanup patches done by adding some more functionality in the OMAP Powerdomain framework. They mostly cleanup OMAP3 but the same ideas can be used/ applied for OMAP4 and beyond.
Quoted 5 lines
The series is based off Teros' series [1] to add usecounting support within the OMAP Powerdomain framework.
The patches are tested with RET/OFF in CPUidle and Suspend on 3630 beagle Xm and 3430 SDP.
This set looks good to me, just requires careful testing that you don't break anything as you are moving lots of stuff around. For debugging purposes (maybe also permanently?), it might be good to keep some sort of failsafe mechanism in place that prevents actual core / per off transitions in case there is a problem with the usecounting, and you accidentally hit core / per off even though the usecounting doesn't expect it (some autoidle mechanism is overlooked for example.)
Quoted 3 lines
Maybe add some caching for the programmed next state, and only program the HW register once we get to the callbacks, and restore the next state to ON after leaving...? This should get rid of any unexpected hangs.ly
Thats exactly what I have been thinking too. The caching is turning out to be a little tricky though. But something like that would certainly be needed, and should also get rid of unwanted (multiple) target state programming.
Quoted 25 lines
-Tero
Quoted 20 lines
regards,
Rajendra[1] http://www.mail-archive.com/linux-omap at vger.kernel.org/msg72163.html
Rajendra Nayak (4):
ARM: OMAP3: cpuidle: Remove unused MPU OSWR support code
ARM: OMAP: PM: Get rid of Powerdomain book-keeping from cpuidle
ARM: OMAP: powerdomain: Add .power_on/.power_down hooks for
powerdomains
ARM: OMAP3: PM: Use .power_on/.power_down to cleanomap_sram_idlearch/arm/mach-omap2/omap-mpuss-lowpower.c | 4 +- arch/arm/mach-omap2/pm34xx.c | 158 ++++++++++++++--------------- arch/arm/mach-omap2/powerdomain.c | 40 ++++---- arch/arm/mach-omap2/powerdomain.h | 8 +- arch/arm/mach-omap2/sleep34xx.S | 4 +- 5 files changed, 104 insertions(+), 110 deletions(-)