at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/3] at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Dear Josh Wu,
Quoted 5 lines · Josh Wu
Hi, Andreas
Sorry, in these patches of current version, it still has a bug, which will fail to write with PMECC, I will send out the v2 patch soon which include this bug fix.
Oups, sorry I had this patch series not on my list. Will review this or v2 these days.
On first sight the first two in series are ok, the third one has style problems:
---8<---
abiessmann@azuregos % ./tools/checkpatch.pl U-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch
WARNING: line over 80 characters
...
total: 1 errors, 27 warnings, 787 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
U-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --->8---
I personally do not really care about the 80 char warning but please remove these for the sake of peace ;) and please have a look for the reported error.
And the last, you should add at least one user of this feature. Isn't the lately applied at91sam9x5ek (is in u-boot-atmel/master and u-boot-arm/master) a perfect user for that?
Quoted 7 lines · Josh Wu
Quoted 6 lines
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is
the modification about registers access part. in this version it via a register structure to access.
A question regarding linux driver. You say it is derived from the kernel driver, but I can not see PMECC stuff in kernel:
---8<---
abiessmann at azuregos % git describe v3.6-rc1-355-gddf343f
abiessmann at azuregos % diff -Nrupa drivers/mtd/nand/atmel_nand.c ../u-boot/drivers/mtd/nand/atmel_nand.c | diffstat
atmel_nand.c | 1231 ++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 720 insertions(+), 511 deletions(-)
abiessmann at azuregos % grep -in pmecc drivers/mtd/nand/atmel_nand* abiessmann@azuregos %
--->8---
Which driver/patch do you mean?
Quoted 1 line
Quoted 1 line
It is tested in atmel 9x5 series board.
Unfortunately I can not test this driver cause I do only have older sam926x devices around.
Best regards
Andreas Bie?mann