at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/3] at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Dear Josh Wu,
Quoted 9 lines · Josh Wu
Hi, Andreas
Thank you for the quick reply.
Quoted 4 lines · Andreas Bie?mann
Dear Josh Wu,
Quoted 1 line · Josh Wu
Hi, Andreas
<snip>
Quoted 8 lines
Quoted 3 lines
And the last, you should add at least one user of this feature. Isn't the lately applied at91sam9x5ek (is in u-boot-atmel/master and u-boot-arm/master) a perfect user for that?
you are right, The PMECC usage is for 9x5ek board.
I planed to push the PMECC support patches in 9x5 board in two part:
one is this series, which only include nand flash driver changes. I
thought those patches should be merged by u-boot mtd maintainer.
I don't care whether Scott Wood or I take the patch (Scott, can you please comment?). If Scott takes it I should ack or the other way round.
Quoted 2 lines
Another part is some patches for 9x5 board file and config file which
enable PMECC in 9x5ek board. Those patches are not sent out yet.
For me it is a must to have at least one user of the added feature.
Quoted 2 lines
Now I think if you can merge all above patches to u-boot mainline, then maybe I can sent those patches together. What do you think about this?
I think there should be one patch in the series enabling the usage of the feature. Who takes this patch is another question but I favor to enable the series in a single step.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Josh Wu
Quoted 7 lines
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is
the modification about registers access part. in this version it via a register structure to access.
Quoted 6 lines
Quoted 2 lines
A question regarding linux driver. You say it is derived from the kernel driver, but I can not see PMECC stuff in kernel:
Sorry, I am not make it clear about this. Actually, The PMECC stuff is not in v3.6-rc1 now, it is queued in kernel MTD maintainer's git tree:
http://git.infradead.org/linux-mtd.git/commit/1c7b874d33b463f7150b1ab4617f000af9b327fd
Ah, I see, just found your mail on the mtd list a couple of minutes ago. I asked just to have something to compare with, I do not want to dive into the specs just to get a clue whats going on.
Quoted 3 lines
Seems the maintainer missed the merge window of v3.6-rc1. I am not sure that can go into v3.6 or not. But I think it is not a bad idea to push those code into u-boot. :)
Me too.
<snip>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
It is tested in atmel 9x5 series board.
Unfortunately I can not test this driver cause I do only have older sam926x devices around.
If I send 9x5 board enable patches with nand PMECC patches together, I think maybe other people can test it in 9x5ed board.
Would be great to get some tested by for the patches.
Best regards
Andreas Bie?mann