Skip to content

remove lock and unlock super

Marco Stornelli linux-ext4 linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8vfs: remove lock and unlock functions for super blockfs/super.c include/linux/fs.h+0 -232 replies
2/8exofs: remove lock/unlock superfs/exofs/super.c+0 -29 replies
3/8ext3: remove lock/unlock superfs/ext3/ext3.h fs/ext3/super.c+7 -55 replies
4/8ext4: remove lock/unlock superfs/ext4/ext4.h fs/ext4/super.c+11 -80 replies
5/8fat: remove lock/unlock superfs/fat/dir.c fs/fat/fat.h fs/fat/inode.c +2 more+36 -340 replies
6/8hpfs: remove lock/unlock superfs/hpfs/super.c+0 -30 replies
7/8sysv: remove lock/unlock superfs/sysv/balloc.c fs/sysv/ialloc.c fs/sysv/inode.c +2 more+20 -180 replies
8/8ufs: remove lock/unlock superfs/ufs/balloc.c fs/ufs/ialloc.c fs/ufs/super.c +1 more+35 -330 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchArtem BityutskiyBoaz Harrosh
1/8
2/8A-b ACK-by
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] remove lock and unlock super

Hi all,

I'm trying to remove the functions lock_super/unlock_super and to push the lock into each single fs. Currently these fs use these functions: ext3, ext4, fat, hpfs, exofs, sysv, ufs. At the moment I used the more conservative approach, I created a new mutex s_lock in the private sb info for each fs, so nothing change but a couple of notes:

1) exofs/hpfs: they use lock_super only in one function so the lock seems completely not needed and I removed it, do you see collateral effect?

2) fat/ufs: they have already got functions to lock the fs with a mutex, I don't know at the moment if a general review of the code can give us the possibility to "merge" the locks.

Bugs, comments, review are welcome especially from fs maintainers. Maybe this work can be a first cleaning, after that each fs can adjust its lock policy.

The patch is against 3.6-rc1.

Marco