Skip to content

rbd: another set of patches

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11rbd: handle locking inside __rbd_client_find()drivers/block/rbd.c+15 -61 reply
2/11rbd: don't over-allocate space for object prefixdrivers/block/rbd.c+0 -01 reply
3/11rbd: kill incore snap_names_lendrivers/block/rbd.c+0 -14 replies
4/11rbd: more cleanup in rbd_header_from_disk()drivers/block/rbd.c+0 -01 reply
5/11rbd: move rbd_opts to struct rbd_devicedrivers/block/rbd.c+1 -13 replies
6/11rbd: add read_only rbd map optiondrivers/block/rbd.c+15 -26 replies
7/11rbd: kill notify_timeout optiondrivers/block/rbd.c+0 -21 reply
8/11rbd: bio_chain_clone() cleanupsdrivers/block/rbd.c+0 -01 reply
9/11rbd: drop needless test in rbd_rq_fn()drivers/block/rbd.c+0 -41 reply
10/11rbd: check for overflow in rbd_get_num_segments()drivers/block/rbd.c+4 -01 reply
11/11rbd: split up rbd_get_segment()drivers/block/rbd.c+0 -01 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchYehuda Sadeh
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] rbd: another set of patches

I keep moving simple and simplifying patches to the front of my patch queue. This is my latest set of things that are ready to get reviewed and committed.

-Alex

[PATCH 01/11] rbd: handle locking inside __rbd_client_find()
This simplifies a little code.
[PATCH 02/11] rbd: don't over-allocate space for object prefix
Don't allocate the max required space for the object prefix. This also ensures that the object prefix is either terminated with '\0' or else is maximally-sized.
[PATCH 03/11] rbd: kill incore snap_names_len
Eliminate an unnecessary field in struct rbd_image_header.
[PATCH 04/11] rbd: more cleanup in rbd_header_from_disk()
Rearrange some code, for better logical grouping.
[PATCH 05/11] rbd: move rbd_opts to struct rbd_device
Tie rbd-specific options to the rbd_device, not the client.
[PATCH 06/11] rbd: add read_only rbd map option
[PATCH 07/11] rbd: kill notify_timeout option
These two were done together, in this order, to preserve the argument parsing code. The first adds the ability to map an rbd image read-only. The second eliminates the only other rbd option, which is otherwise unused.
[PATCH 08/11] rbd: bio_chain_clone() cleanups
Simple refactoring.
[PATCH 09/11] rbd: drop needless test in rbd_rq_fn()
Trivial.
[PATCH 10/11] rbd: check for overflow in rbd_get_num_segments()
Make sure we don't exceed 64-bit maximum when adding offset and length.
[PATCH 11/11] rbd: split up rbd_get_segment()
Refactor rbd_get_segment() into three separate functions, which return a segment name, offset, and length.