Skip to content

gpio-twl4030: add new device tree properties

Benoit Cousson linux-arm-kernel linux-devicetree linux-omap 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 0 repliesNew
  2. v2 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v10 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpio/twl4030: get platform data from device treeDocumentation/devicetree/bindings/gpio/gpio-twl4030.txt drivers/gpio/gpio-twl4030.c+61 -271 reply
1/2gpio/twl4030: get platform data from device tree+0 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijVaibhav Hiremath
1/2A-b A-b
1/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] gpio-twl4030: add new device tree properties
Quoted 34 lines · Tony Lindgren
Quoted 33 lines · Benoit Cousson

Hi Florian,

Quoted 8 lines · Florian Vaussard

Hello,

A number of platform data are missing when using twl4030/gpio from a device tree. This patchset adds the missing properties, updates the documentation with the new bindings, and updates existing device trees. It mainly enables LEDA and LEDB outputs, as well as pullups / pulldowns on GPIOs.

Quoted 8 lines

The 1st patch changes the device driver and updates the documentation. The 2nd patch updates the device trees for BeagleBoard and omap3-evm.

Changes since v1:
- Patches on driver and documentation merged into the same patch
- Put device trees' values in hexadecimal
- Handle bool property using of_property_read_bool()
- Prefix the patches with the correct convention

Thanks for the update.

Quoted 1 line

Tested on Gumstix Overo. V1 was tested on omap3-evm by Vaibhav Hiremath.

I've just tested it on beagle xM. I can play with D12 led using:

echo 255 > /sys/class/leds/beagleboard\:\:pmu_stat/brightness

Tested-by Benoit Cousson <[email protected]>
Quoted 1 line

BTW: who will merge this?

Quoted 8 lines
Quoted 6 lines

Since Linus already acked it, Tony can merge it.

Tony,

I can add that series in my DTS series for 3.7 if you want.

Yes please do thanks.

On top of that series, I realized that beagle was missing the other LEDs. So I've just posted the support for the two missing ones.

[PATCH] ARM: dts: omap3-beagle: Add heartbeat and mmc LEDs support

Regards,
Benoit

Read the cover letter in its thread