rbd: code cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rbd: define rbd_assert()drivers/ | +16 | 1 reply | |
| 2/5 | rbd: rename rbd_id_get()drivers/ | +0 | 1 reply | |
| 3/5 | rbd: rename __rbd_init_snaps_header()drivers/ | +1 | 1 reply | |
| 4/5 | rbd: kill rbd_dev->qdrivers/ | +0 | 1 reply | |
| 5/5 | rbd: kill rbd_image_header->total_snapsdrivers/ | +0 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Josh Durgin |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] rbd: code cleanup
This second series consists of fairly simple bits of code cleanup.
It is available as branch "wip-rbd-review-2" on the ceph-client git repository, and is based on the branch "wip-rbd-review-1".
https://github.com/ceph/ceph-client/tree/wip-rbd-review-2
-Alex
[PATCH 1/5] a0f6877 rbd: define rbd_assert()
This defines a new macro rbd_assert() that's used to express invariant properties assumed by the code. If the property does not hold it triggers a BUG(). Everywhere that BUG_ON() had been used is replaced with an equivalent call to rbd_assert().
[PATCH 2/5] a8aac82 rbd: rename rbd_id_get()
[PATCH 3/5] 12c5aa2 rbd: rename __rbd_init_snaps_header()
These rename some symbols to align better with how their used.
[PATCH 4/5] e8cb272 rbd: kill rbd_dev->q
[PATCH 5/5] 1557afc rbd: kill rbd_image_header->total_snaps
These eliminate two struct fields, one which is unused and the other which is redundant and therefore not necessary.