rbd: isolate mapping info, rearrange init
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | rbd: separate mapping info in rbd_devdrivers/ | +13 | 2 replies | |
| 2/7 | rbd: record mapped sizedrivers/ | +1 | 2 replies | |
| 3/7 | rbd: return snap name from rbd_add_parse_args()drivers/ | +0 | 1 reply | |
| 4/7 | rbd: set mapping name with the restdrivers/ | +0 | 1 reply | |
| 5/7 | rbd: simplify snap_by_name() interfacedrivers/ | +0 | 1 reply | |
| 6/7 | rbd: do some header initialization earlierdrivers/ | +27 | 1 reply | |
| 7/7 | rbd: simplify rbd_init_disk() a bitdrivers/ | +3 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Josh Durgin |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] rbd: isolate mapping info, rearrange init
This third series begins a little more interesting code restructuring. The first five patches make more clear the distinction in a struct rbd_device between information about the underlying rbd image and information about the mapped snapshot represented by the structure.
The last two patches (which might arguably belong in a later sub-series) move some initialization code out of one function and into its caller.
It is available as branch "wip-rbd-review-3" on the ceph-client git repository, and is based on the branch "wip-rbd-review-2".
https://github.com/ceph/ceph-client/tree/wip-rbd-review-3
-Alex
[PATCH 1/7] f4069bf rbd: separate mapping info in rbd_dev
This groups some related fields of an rbd device structure into a sub-structure. The fields pertain to the specific mapping an rbd_device represents--as opposed to the base rbd image.
[PATCH 2/7] bee627f rbd: record mapped size
This adds the size of the image or snapshot that's mapped to an rbd device's mapping information.
[PATCH 3/7] 8b45382 rbd: return snap name from rbd_add_parse_args() [PATCH 4/7] cb93cc4 rbd: set mapping name with the rest
These two patches make the name of the mapped snapshot be set along with the other mapping-related fields.
[PATCH 5/7] 8a245ce rbd: simplify snap_by_name() interface
This does some refactoring enabled by the previous few patches.
[PATCH 6/7] e4008bd rbd: do some header initialization earlier
This rearranges where certain initialization is done, beginning the process of re-ordering some of these steps in order to allow both format 1 and format 2 rbd images to be handled in the same way.
[PATCH 7/7] 275ba12 rbd: simplify rbd_init_disk() a bit
This does some refactoring enabled by the previous patch.