rbd: kill create_snap sysfs entry
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rbd: pass flags to rbd_req_sync_exec()drivers/ | +15 | 1 reply | |
| 2/5 | rbd: support data returned from OSD methodsdrivers/ | +2 | 1 reply | |
| 3/5 | rbd: define some new format constantsdrivers/ | +20 | 1 reply | |
| 4/5 | rbd: define rbd_dev_image_id()Documentation/ drivers/ | +17 | 1 reply | |
| 5/5 | rbd: kill create_snap sysfs entryDocumentation/ drivers/ | +0 | 1 reply |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Josh Durgin |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] rbd: kill create_snap sysfs entry
The point of this sixth series is as the subject indicates--to get rid of the /sys/bus/rbd/create_snap entry. There is no need to provide this functionality via the kernel client, it is done quite well using the user space "rbd" command.
Simply removing the functionality would leave rbd_req_sync_exec() with no other references though, and we'll be making quite a bit of use of that function in supporting format 2 rbd images.
So this series inserts a patch that adds another function we will want that will make use of rbd_req_sync_exec(). And that patch requires the other three as prerequisites as well--supporting data returned from requests made via rbd_req_sync_exec(), then using the function to perform new "image_id" retrieval operation on a special image id file used for version 2 images.
It is available as branch "wip-rbd-review-6" on the ceph-client git repository, and is based on the branch "wip-rbd-review-5".
https://github.com/ceph/ceph-client/tree/wip-rbd-review-6
-Alex
[PATCH 1/5] 1ab7ae5 rbd: pass flags to rbd_req_sync_exec() [PATCH 2/5] 44a187e rbd: support data returned from OSD methods [PATCH 3/5] f1e1bff rbd: define some new format constants [PATCH 4/5] 574d0d3 rbd: define rbd_dev_image_id() [PATCH 5/5] 48080a0 rbd: kill create_snap sysfs entry