Rework the gettext handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 2/25 of 11 patches 0 repliesNew
- v3 posting 1/20 of 11 patches 0 repliesSuperseded
5 of 11 patches are in this archive. The cover letter announces 11.
Patches in v3 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 5/11 | gettext: convert to autotools-package | +0 | 0 replies | |
| 5/11 | gettext: convert to autotools-package | +0 | 1 reply | |
| 9/11 | toolchain/common: rename BR2_NEEDS_GETTEXT | +0 | 1 reply | |
| 10/11 | toolchain/common: introduce blind options BR2_NEEDS_GETTEXT{, _IF_LOCALE} | +0 | 1 reply | |
| 10/11 | toolchain/common: introduce blind options BR2_NEEDS_GETTEXT{, _IF_LOCALE} | +0 | 0 replies |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| 5/11 | A-b T-b |
| 5/11 | A-b T-b |
| 9/11 | |
| 10/11 | |
| 10/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/11 v3] Rework the gettext handling
Quoted 3 lines · Yann E. MORIN
- fix conversion to autotools to always build libintl, even if locales are disabled, to fix packages that always require NLS
- thus removed Arnout's Tested-by on patch 5/11, as it has changed
Goes to show how valuable my testing was :-(
How about finding and fixing the packages that require NLS?
But then, Samuel's remark becomes valid: if ENABLE_LOCALE is not true,
then libintl won't be built, so the -lintl becomes invalid. In fact, I would think that packages that select BR2_NEEDS_EXTERNAL_GETTEXT should actually depend on ENABLE_LOCALE... Or usually they should be ..._IF_LOCALE instead. For instance, I tried util-linux and it builds perfectly without locale and gettext.
Any chance of testing if the cases that have gettext without -if-locale
can be replaced with gettext-if-locale?
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F