Skip to content

libcman: fix possible string nontermination

Christine Caulfield cluster-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [PATCH 0/3] libcman: fix possible string nontermination

in RHEL6 those strings are copied using strcpy - I think it was changed in the STABLE branch to strncpy after a coverity scan

TBH the original strcpy is quite safe as the strings come from internal sources and are pre-validated.

Anyway, the arrays are allocated as size+1 so the strings will never overflow.

NACK.

Quoted 13 lines · Jan Pokorn?

Hello once more,

I discovered cases potentially leading to string overruns later in the processing.

Jan Pokorn? (3):
libcman: fix possible string nontermination: node name
libcman: fix possible string nontermination: barrier name
libcman: fix possible string nontermination: barrier name

  cman/lib/libcman.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)