Skip to content

serial: sh-sci fixes - console PM, SCIFB, SMP lockup, etc.

Shinya Kuribayashi linux-arm-kernel linux-serial linux-sh 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 0 repliesNew
  2. v10 of 10 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10Revert "sh-sci / PM: Avoid deadlocking runtime PM"drivers/tty/serial/sh-sci.c+0 -50 replies
2/10Revert "sh-sci / PM: Use power.irq_safe"drivers/tty/serial/sh-sci.c+0 -10 replies
3/10Partially revert "serial: sh-sci: console Runtime PM support"drivers/tty/serial/sh-sci.c+1 -520 replies
4/10serial: sh-sci: console runtime PM support (revisit)drivers/tty/serial/sh-sci.c+16 -110 replies
5/10serial: sh-sci: fix condition test to set SCBRRdrivers/tty/serial/sh-sci.c+1 -10 replies
6/10serial: sh-sci: support lower baud ratedrivers/tty/serial/sh-sci.c+8 -110 replies
7/10serial: sh-sci: mask SCTFDR/RFDR according to fifosizedrivers/tty/serial/sh-sci.c+2 -20 replies
8/10serial: sh-sci: fix common SCIFB regmap definitiondrivers/tty/serial/sh-sci.c+3 -30 replies
9/10serial: sh-sci: add locking to console write function to avoid SMP lockupdrivers/tty/serial/sh-sci.c+22 -10 replies
10/10serial: sh-sci: fix possible race cases on SCSCR register accessesdrivers/tty/serial/sh-sci.c+6 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/10] serial: sh-sci fixes - console PM, SCIFB, SMP lockup, etc.

Hi Greg,

Quoted 15 lines · Shinya Kuribayashi
Quoted 15 lines · Shinya Kuribayashi
Quoted 1 line

Hi Paul and serial forks,

[...]

Quoted 11 lines

Takashi YOSHII (4):
serial: sh-sci: fix condition test to set SCBRR
serial: sh-sci: support lower baud rate
serial: sh-sci: mask SCTFDR/RFDR according to fifosize
serial: sh-sci: fix common SCIFB regmap definition

Teppei Kamijou (1):
serial: sh-sci: console runtime PM support (revisit)

 drivers/tty/serial/sh-sci.c | 140 ++++++++++++++++++--------------------------
 1 file changed, 56 insertions(+), 84 deletions(-)
Quoted 7 lines
Quoted 4 lines

Oops, I forgot to append proper From: author lines in five commits (patch 04/10 to 09/10). Didn't mean to supersede your authoship.

I'd respin the patchset later, waiting for some feedback.

Can you please resend this with this fixed up if you want to get this into 3.8?

Thanks for your kind reminder. Here's v2, providing From: authorship lines in five patches (04 to 08). No logical change in the patches.

--- 8< ---

V2: provide missing authorship From: lines in five patches (04 to 08)

Here are sh-sci serial driver fixes that have been cooking for months privately on my end:
* rework console PM with the help of serial-core's uart_change_pm()
* provide missing piece in SCIFB support (from Yoshii-san)
* address console write function vs. SMP lockup issue

and so on. Comments and suggestions are welcome.

Build tested with vanilla v3.6, but not boot- nor PM-tested with newer kernels after v3.4. Anyone with can-sleep shmobile systems, please give it try.

Thanks in advance,

----------------------------------------------------------------
Shinya Kuribayashi (5):
Revert "sh-sci / PM: Avoid deadlocking runtime PM"
Revert "sh-sci / PM: Use power.irq_safe"
Partially revert "serial: sh-sci: console Runtime PM support"
serial: sh-sci: add locking to console write function to avoid SMP lockup
serial: sh-sci: fix possible race cases on SCSCR register accesses

Takashi YOSHII (4):
serial: sh-sci: fix condition test to set SCBRR
serial: sh-sci: support lower baud rate
serial: sh-sci: mask SCTFDR/RFDR according to fifosize
serial: sh-sci: fix common SCIFB regmap definition

Teppei Kamijou (1):
serial: sh-sci: console runtime PM support (revisit)

 drivers/tty/serial/sh-sci.c | 140 ++++++++++++++++++--------------------------
 1 file changed, 56 insertions(+), 84 deletions(-)
Signature · 2 lines
Shinya Kuribayashi
Renesas Electronics