MCE: fix an error of mce_bad_pages statistics
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/23 patches 0 repliesNew
- v4 posting 1/23 patches 6 repliesSuperseded
- v32 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 1 patch | 37 replies | Superseded | |
| v1 | 1 patch | 3 replies | Superseded |
Changes in v4 from the cover letter
-use num_poisoned_pages instead of mce_bad_pages -remove page lock
Patches in v4 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | MCE: fix an error of mce_bad_pages statisticsmm/ | +17 | 0 replies | |
| 2/3 | MCE: do code refactor of soft_offline_pagemm/ | +20 | 0 replies | |
| 3/3 | MCE: use num_poisoned_pages instead of mce_bad_pagesfs/ include/ mm/ | +10 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Naoya Horiguchi | Wanpeng Li |
|---|---|---|
| 1/3 | T-b | |
| 2/3 | ||
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V4 0/3 RESEND] MCE: fix an error of mce_bad_pages statistics
$ echo paddr > /sys/devices/system/memory/soft_offline_page to offline a *free* page, the value of mce_bad_pages will be added, and the page is set HWPoison flag, but it is still managed by page buddy alocator.
$ cat /proc/meminfo | grep HardwareCorrupted shows the value.
If we offline the same page, the value of mce_bad_pages will be added *again*, this means the value is incorrect now. Assume the page is still free during this short time.
soft_offline_page()
get_any_page() "else if (is_free_buddy_page(p))" branch return 0 "goto done"; "atomic_long_add(1, &mce_bad_pages);"
Changelog:
V4:
-use num_poisoned_pages instead of mce_bad_pages -remove page lock
V3:
-add page lock when set HWPoison flag -adjust the function structure
V2 and V1:
-fix the error
Xishi Qiu (3):
move-poisoned-page-check-at-the-beginning-of-the-function fix-function-structure use-num_poisoned_pages-instead-of-mce_bad_pages
fs/proc/meminfo.c | 2 +- include/linux/mm.h | 2 +- mm/memory-failure.c | 76 ++++++++++++++++++++++++++------------------------- 3 files changed, 41 insertions(+), 39 deletions(-)
.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>