Skip to content

rbd: consolidate osd request setup

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6rbd: don't assign extent info in rbd_do_request()drivers/block/rbd.c+0 -70 replies
2/6rbd: don't assign extent info in rbd_req_sync_op()drivers/block/rbd.c+0 -00 replies
3/6rbd: initialize off and len in rbd_create_rw_op()drivers/block/rbd.c+0 -10 replies
4/6rbd: define generalized osd request op routinesdrivers/block/rbd.c+0 -00 replies
5/6rbd: move call osd op setup into rbd_osd_req_op_create()drivers/block/rbd.c+5 -30 replies
6/6rbd: move remaining osd op setup into rbd_osd_req_op_create()drivers/block/rbd.c+0 -13 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Durgin
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH REPOST 0/6] rbd: consolidate osd request setup

This series consolidates and encapsulates the setup of all osd requests into a single function which takes variable arguments appropriate for the type of request. The result groups together common code idioms and I think makes the spots that build these messages a little easier to read.

-Alex

[PATCH REPOST 1/6] rbd: don't assign extent info in rbd_do_request() [PATCH REPOST 2/6] rbd: don't assign extent info in rbd_req_sync_op() [PATCH REPOST 3/6] rbd: initialize off and len in rbd_create_rw_op() [PATCH REPOST 4/6] rbd: define generalized osd request op routines [PATCH REPOST 5/6] rbd: move call osd op setup into rbd_osd_req_op_create() [PATCH REPOST 6/6] rbd: move remaining osd op setup into rbd_osd_req_op_create()