Skip to content

Add fully tested id switch and vbus connect detect support for Chipidea

Maxime Ripard linux-arm-kernel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/20 of 7 patches 0 repliesNew
  2. v4 posting 1/20 of 7 patches 0 repliesSuperseded

Patches in v4 posting 2/2 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

Hi Peter,

Thanks for your answer.

Quoted 18 lines · Peter Chen
Quoted 17 lines · Maxime Ripard

Hi Peter,

Quoted 13 lines · Peter Chen

(Sorry for update slowly due to long time business trip)

Changes for v4 mainly for 2/7, 3/7, 4/7, see individual patch commit for detail.

This patchset adds fully tested otg id switch function and vbus connect/disconnect detection for chipidea driver. The mainly design of id/vbus handling follows msm otg driver. I hope the msm usb maintainer can have a look of this patchset, and give some comments, and move the whole msm usb driver to chipidea framework if possible in the future.

This patchset is fully tested at i.mx6Q saberlite board.

Quoted 7 lines
Quoted 1 line

Have you tested it on a 3.8 kernel?

Hi Maxime,

I just tested my branch (https://github.com/hzpeterchen/linux-usb)
It works ok at i.mx6Q saberlite board.
The version is Linux version 3.8.0-rc2+, and it is based on greg's usb-next(top of 102ee001912f67a7701f26a56ef2bcf84fc78028).

Ok, I finally got what's going on.

Commit 09f6ffde introduced a dependency on USB_EHCI_HCD for host mode, that in turn depends on USB_ARCH_HAS_EHCI, which isn't selected by MXS. It was thus removing the host mode support when switching from 3.7 to 3.8, and I somehow overlooked that.
Enabling the host mode solved the panic.

Quoted 4 lines

Please always enable both device and host mode for chipidea driver. Current code still not consider all things for different mode config, like device-only, host-only, otg. In future, it is supposed to do at dts file, and judge probe.

Then isn't the gadget mode configuration option supposed to depends on the host mode if it's known to be broken otherwise?

Thanks,
Maxime

Signature · 4 lines
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Read the cover letter in its thread