at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 3/30 of 5 patches 0 repliesNew
- v3 posting 2/30 of 5 patches 0 repliesSuperseded
- v3 posting 1/35 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 0 replies | Superseded | |
| v1 | 0 of 3 patches | 0 replies | Superseded |
Patches in v3 posting 3/3 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH 0/5 v3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek
Hi, Olof
Quoted 31 lines · Olof Johansson
Quoted 24 lines · Nicolas Ferre
On 01/23/2013 01:47 PM, Josh Wu :
Quoted 16 lines
Those patches will enable PMECC in dt parameters for at91sam9x5ek and at91sam9n12ek.
The PMECC driver will check minimum required ecc on ONFI parameter from NAND flash.
If pmecc-cap, pmecc-sector-size in dts file is specified, use those two. otherwise, set those according to NAND flash ONFI parameters.
If the pmecc-cap, pmecc-sector-size in dts are different with ecc requirement in ONFI, print out a warning.
For the following compile error:
ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx"Quoted 7 lines
ERROR: Input tree has errors, aborting (use -f to force output) make[2]: *** [
arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2the fixes are already merged in Linux mainline in v3.8-rc4.
you can find in:
544ae6b2e676c3c37fb8c93ef9327932fc2e5bc2(ARM: at91/dts: add pinctrl support for SSC peripheral)ea03c81521bde526570e1dec96eaa21fe5ac84a2(ASoC: atmel-ssc: add pinctrl selection to driver)Quoted 6 lines
Artem,
I propose to take patches 2 and 3/5 of this series via arm-soc git tree. I will specify to merge them at the end of the merge-window so that the Device Tree properties will not be out-of-sync with driver modifications (may not cause big issues anyway).
Quoted 8 lines
I'm not cc:d on the patches, but if it's just new properties then there's no reason to hold off to "late in the merge window". There's actually no way for you to hold that off yourself, since we won't accept new patches to arm-soc that late.
I don't see any cc to devicetree-discuss of the device tree bindings though, and no update of
Documentation/device-tree/bindings/, so the patches are not ready to go in yet.
Since in my commit: a41b51a1f7c15a1b00f30a3ad2d0373ad51b883d (mtd: at91:
add dt parameters for Atmel PMECC), it already added following properties to DT documentation:
atmel,pmecc-cap
atmel,pmecc-sector-size
atmel,pmecc-lookup-table-offset
so in this patches series, NO. 2 and 3 just add it to at91 board's dts file according to the DT documentation.
Indeed, this patch series make a little bit different from the DT documentation, that is: the ROM code mapping size are smaller than the DT documentation example.
But original DT documentation example still works.
So I think the DT documentation's explanation are proper for this patch series. It seems I don't have to update the DT documentation so far.
Quoted 3 lines
-Olof
Best Regards,
Josh Wu