Skip to content

libceph: osd_client should not take bio reference

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2libceph: add a compatibility check interfaceinclude/linux/ceph/libceph.h net/ceph/ceph_common.c+18 -01 reply
2/2rbd: don't take extra bio reference for osd clientdrivers/block/rbd.c net/ceph/ceph_common.c net/ceph/osd_client.c+3 -62 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJosh Durgin
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] libceph: osd_client should not take bio reference

Currently when the osd client gets a request that involves a bio list, it assumes the initiator (the rbd client) has taken an extra reference to the first bio on that list. When the request is done, the initiator calls ceph_osdc_release_request() and at that time the osd client drops that presumed reference.

The second patch in this series simply gets rid of that extra reference entirely, because it's not needed. Doing this creates an incompatibility between differing versions of both rbd and the osd client (libceph). So The first patch adds a simple compatibility check capability so it's possible to avoid that causing any problems.

-Alex

[PATCH 1/2] libceph: add a compatibility check interface [PATCH 2/2] rbd: don't take extra bio reference for osd client