Skip to content

Fix acpi_bus_get_device() check

Yasuaki Ishimatsu dri-devel linux-acpi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.cdrivers/acpi/device_pm.c+3 -33 replies
2/4ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.cdrivers/acpi/dock.c+1 -10 replies
3/4PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.cdrivers/pnp/pnpacpi/core.c+5 -50 replies
4/4GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.cdrivers/gpu/drm/i915/intel_opregion.c+1 -11 reply
4/4GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.cdrivers/gpu/drm/i915/intel_opregion.c+1 -13 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Fix acpi_bus_get_device() check

Some functions use ACPI_SUCCESS/FAILURE for checking return value of acpi_bus_get_device().

Following patches change not to apply ACPI_SUCCESS/FAILURE to the return value of acpi_bus_get_device().

[PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c [PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c [PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c [PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

Quoted 33 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Since acpi_bus_get_device() returns int and not acpi_status, change acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the return value of acpi_bus_get_device().

Signed-off-by Rafael J. Wysocki <[email protected]>
---
  drivers/acpi/scan.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/scan.c
===================================================================

drivers/acpi/scan.c +2 -3
@@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
  					       const struct device *dev)
  {
  	struct acpi_device *adev;
+	acpi_handle handle = ACPI_HANDLE(dev);
 
-	if (!ids || !ACPI_HANDLE(dev)
-	    || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
+	if (!ids || !handle || acpi_bus_get_device(handle, &adev))
  		return NULL;
 
  	return __acpi_match_device(adev, ids);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Read the cover letter in its thread