Skip to content

target: OOPS in target_fabric_port_link on v3.7.4 and v3.4.27

Ben Peddell lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23.4.y target: Move dev->dev_link_magic checkdrivers/target/target_core_fabric_configfs.c+6 -60 replies
2/23.7.y target: Move dev->dev_link_magic checkdrivers/target/target_core_fabric_configfs.c+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] target: OOPS in target_fabric_port_link on v3.7.4 and v3.4.27

There is an OOPS in target_fabric_port_link due to a use before initialization error.

commit 0ff8754981261a80f4b77db2536dfea92c2d4539 (target: Add link_magic for fabric allow_link destination target_items) as merged in the linux-3.7.y and linux-3.4.y branches relies on one of the changes that occurred in commit 0fd97ccf45be26fb01b3a412f1f6c6b5044b2f16 (Simplify the code a lot by killing the superflous struct se_subsystem_dev). Without that change, dev is dereferenced before it is initialized.

Commit 0fd97ccf45be26fb01b3a412f1f6c6b5044b2f16 looks too invasive, which I would guess would be why it wasn't merged in.

One option would be to move the dev->dev_link_magic test to after dev is initialized, as presented the patches I will be following up with.

An alternative that will resolve this OOPS is to revert commit fdf9d862969f1be18814273b03fb9497ec2dbdae (target: Add link_magic for fabric allow_link destination target_items) on branch linux-3.7.y, and revert commit 92a7389317838f3338466df0c0e3d23ad33cb1f4 (target: Add link_magic for fabric allow_link destination target_items) on branch linux-3.4.y