Create an API for safely accessing BMP header fields
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields
Hello Wolfgang,
Quoted 12 lines · Wolfgang Denk
Dear Nikita Kiryanov,
Quoted 4 lines · In message <[email protected]> you wrote:
I did mention that I consider that fix as temporary. I believe this fix is better because it addresses the issue everywhere and does so in a more maintainable way (does not require the address fix to be duplicated everywhere there is a problem).
Can you please explain (again) what exactly you consider the problem?
That I can load a BMP image to anodd address, and that this will result in odd results?
If you use eldk 5.3, a board will be bricked if you set the load address to not (an aligned address _+ 2_). So anyone who didn't know the +2 requirement, has a bricked board (and can't recover). So this is really a different then md trapping, since resetting the board won't help... it is broken / kaput.
That said, I am not really in favor of this solution. But I do think it needs
to be fixed.
Regards,
Jeroen