Skip to content

SERIAL: OMAP: Remove idle handling from driver

Santosh Shilimkar linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver
Quoted 10 lines · Felipe Balbi
Quoted 9 lines · Felipe Balbi
Quoted 3 lines

HWMOD_SWSUP_SIDLE flag will is not what will help UART completely. Also considering UART also needs async wakeup enabled as it implements another such hook and attaches that through function pointer.

this is exactly what I said at [1], which I quote:

"Also, $SUBJECT isn't improving the situation regarding UART Wakeup, there is still the regression of UART never being wakeup capable.

I also mentioned that am not touching the wakeup function pointer. The reason an alternate is needed because wakeup function pointer back-end comes in between. And the existing SW control flag isn't intended completely for the purpose what we wanted to use for uart. And I didn't expected the wakeup crap will come in between an implementation of just slave idle bits.

Quoted 5 lines
Quoted 2 lines

I wonder what are your ideas to sort that part out, I mean, how do you plan to implement ->set_wake() for the tty port ?"

[1] http://marc.info/?l=linux-omap&m=136093334914275&w=2

The main need for uart wakeup is the io_ring() trigger and that needs to happen via generic pin control API. SYSC wakeup bit isn't something needs to be toggled so that can be decoupled. So again the idea is to make SYSC handling transparent to UART drivers and let driver toggle the io_ring() based on ->set_wake() as it is done today.

Regards,
Santosh