Skip to content

SERIAL: OMAP: Remove idle handling from driver

Santosh Shilimkar linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver
Quoted 18 lines · Felipe Balbi
Quoted 17 lines · Felipe Balbi

Hi,

Quoted 10 lines · Santosh Shilimkar
Quoted 5 lines
Quoted 2 lines

I wonder what are your ideas to sort that part out, I mean, how do you plan to implement ->set_wake() for the tty port ?"

[1] http://marc.info/?l=linux-omap&m=136093334914275&w=2

The main need for uart wakeup is the io_ring() trigger and that needs to happen via generic pin control API. SYSC wakeup bit isn't something needs to be toggled so that can be decoupled. So again the idea is to make SYSC handling transparent to UART drivers and let driver toggle the io_ring() based on ->set_wake() as it is done today.

We're either reading different code bases or not understanding each other. Currently this is how ->set_wake() is implemented:

Quoted 6 lines
Quoted 6 lines

serial_omap_set_wake()
serial_omap_enable_wakeup()
omap_uart_enable_wakeup()
omap_hwmod_enable_wakeup()
if (SYSC_HAS_ENAWAKEUP) { /* true for UART */
_enable_wakeup()

There is no need to toggle this one. It can be set once and left as is.

Quoted 3 lines
Quoted 3 lines
      _write_sysconfig()
     }
     set_idle_ioring_wakeup()

So this is the part, we need to hookup with pads.

Quoted 11 lines
Quoted 7 lines
      if (!oh->mux || !oh->mux->enabled)
       return;

If I read the code correctly there's nothing setting oh->mux during DT boot. The only caller to omap_hwmod_mux_init() (which allocates and returns omap_hwmod_mux_info pointer) is arch/arm/mach-omap2/devices.c::omap4_keyboard_init(). This has nothing

actually arch/arm/mach-omap2/serial.c::omap_serial_init_port() also calls that, but it's also not used during DT boots.

DT boot, all the function pointers are broken so wakeup as well as slave idle-mode is broken. Nothing new here. Serial file does set the pads as you noticed and this is what can be offloaded to generic pint control which can triggered from driver.

Regards,
Santosh