Skip to content

SERIAL: OMAP: Remove idle handling from driver

Santosh Shilimkar linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver
Quoted 11 lines · Felipe Balbi

Hi,

Quoted 8 lines · Santosh Shilimkar
Quoted 8 lines
Quoted 4 lines

If I read the code correctly there's nothing setting oh->mux during DT boot. The only caller to omap_hwmod_mux_init() (which allocates and returns omap_hwmod_mux_info pointer) is arch/arm/mach-omap2/devices.c::omap4_keyboard_init(). This has nothing

actually arch/arm/mach-omap2/serial.c::omap_serial_init_port() also calls that, but it's also not used during DT boots.

Quoted 7 lines
Quoted 4 lines

DT boot, all the function pointers are broken so wakeup as well as slave idle-mode is broken. Nothing new here. Serial file does set the pads as you noticed and this is what can be offloaded to generic pint control which can triggered from driver.

fair enough, understood now.

Just keep the thread posted, the slave idle handling with *wakeup* bit is sorted out now. We are looking at the io_ring() and pad wakeup stuff now. Once we have that working, we will repost the series.

Regards,
Santosh