Skip to content

libceph clean up con_work()

Alex Elder ceph-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v15 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5libceph: encapsulate connection backoffnet/ceph/messenger.c+0 -00 replies
2/5libceph: separate non-locked fault handlingnet/ceph/messenger.c+23 -190 replies
2/5libceph: separate non-locked fault handlingnet/ceph/messenger.c+23 -191 reply
3/5libceph: use a flag to indicate a fault has occurrednet/ceph/messenger.c+12 -120 replies
4/5libceph: use a do..while loop in con_work()net/ceph/messenger.c+20 -190 replies
5/5libceph: indent properlynet/ceph/messenger.c+40 -400 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/5, v2] libceph clean up con_work()

(Re-posting because these changes have been rebased.)

This series cleans up con_work() a bit. The original motivation was to get rid of a warning issued by the sparse utility, but addressing that required a little rework and it was fairly straightforward once that was done to make that function fairly simple.

The problem sparse reported was really due to sparse not being able to follow the logic between multiple functions that together implement locking. The result of these changes makes both acquiring and releasing the connection mutex occur in con_work().

-Alex

[PATCH 1/5] libceph: encapsulate connection backoff [PATCH 2/5] libceph: separate non-locked fault handling [PATCH 3/5] libceph: use a flag to indicate a fault has occurred [PATCH 4/5] libceph: use a do..while loop in con_work() [PATCH 5/5] libceph: indent properly