Skip to content

ARM: mmu: Set domain permissions to client access - build warnings!

Tom Rini u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchVincent Stehle
SeriesT-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] ARM: mmu: Set domain permissions to client access - build warnings!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 39 lines · Albert ARIBAUD

Hi Sricharan,

Quoted 34 lines · Sricharan R

Hi Albert,

Quoted 31 lines · Albert ARIBAUD
Quoted 28 lines · Albert ARIBAUD

(sorry for any duplicate of this mail)

Hi R Sricharan,

Quoted 21 lines · R Sricharan

Currently for ARM based cpu's, mmu pagetable attributes are set with manager permissions for all 4GB address space. Because of this the 'execute never (XN)' permission is never checked on read sensitive regions which results in speculative aborts.

This series changes the domain permissions of the full 4GB space to client access for OMAP socs. This avoids all the speculative aborts that are currently seen on OMAP5 secure devices.

Tested on OMAP5 SDP (HS) soc.

This series depends on [1] the patch sent by <Vincent Stehle<[email protected]>

[1]
http://www.mail-archive.com/u-boot at lists.denx.de/msg102709.html

R Sricharan (2):

Quoted 38 lines
Quoted 26 lines
Quoted 26 lines
Quoted 11 lines
Quoted 11 lines

ARM: mmu: Introduce weak dram_bank_setup function ARM: mmu:
Set domain permissions to client access

arch/arm/cpu/armv7/cache_v7.c | 3 ++
arch/arm/cpu/armv7/omap-common/hwinit-common.c | 35
++++++++++++++++++++++++ arch/arm/include/asm/cache.h
| 1 + arch/arm/include/asm/system.h |
14 ++++++++++ arch/arm/lib/cache-cp15.c
| 13 ++++++++- 5 files changed, 65 insertions(+), 1
deletion(-)

Quoted 1 line

Series applied to u-boot-arm/master, thanks!

Correction: I'd wrongly inferred from the testing done on OMAP5 that the series would build fine. However it appears that for targets omap4_sdp4430, omap4_panda and omap5_evm, patch 2/2 has warnings:

hwinit-common.c: In function 'dram_bank_mmu_setup':
hwinit-common.c:279:3: warning: implicit declaration of function 'set_section_dcache' [-Wimplicit-function-declaration]

Luckily, I had not committed to the git repo yet.

R Sicharan, can you please check and fix this warning?

Quoted 7 lines
Quoted 1 line

Amicalement,

Oh, thats because as i mentioned above, it depends on the below patch from vincent .

http://www.mail-archive.com/u-boot at lists.denx.de/msg102709.html

I did not repost it though. I will do it now for clarity.

Ok -- Vincent's patch was not in my Patchwork TODO and I had read patches 1/2 and 2/2 in Patchwork, but I had not read the cover letter thoroughly enough so I had missed the dependency.

Quoted 5 lines

(Cc:ing Vincent and Tom)

Vincent's patch series is delegated to Tom and marked "superseded" in Patchwork but I don't see any later, superseding, series. What can/should I make of it?

It's possible I mis-read things and it shouldn't be superseded. Can you list all of the patches that Albert should apply please? Thanks!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRMLl9AAoJENk4IS6UOR1WPX4P+wRRwsSgPm5edbbBN/TkBi6a x1LIMEKYC2QN73ea8czz4oeOR76MXidQUdYRmimJ2qzYRaEq9Y9ulFjIs0zc/6Gu ydnO4eeb8keU27ItlmKubnEOwsev/wtZNIQhvwJJNvuSiG9rBvKAGDh9L8UQrq3t cwhqWpNhL4isoYG/rB2BDHKrwB62DboOzmaNHACpVaCZNg606QH+eHnget1CWBCD p2O88TSkOVoQHVAj76mdgm8+9WE/mlqn5h4RUU81U3DHiAuTDg0N+J1IJPd3zjhP 86zvj1q4i3JuZySg+IdxouiPTqnw88ZYJ2XHtQvAeDGr5Q680Gb1k18vMIRGlNtv AVx9ipQHaOFXSbTQzlmTNT4EutseaGVa5Ioj3vUkRozBONIfuDmEZAnE+YXFfgQV OQZzidbWLOSFbfDPSi6XMUgtXVEtUPP6eGPV0sv5HUvfYr+3zUMtFwdGqe47X1lC z5V1xpug2mOvU0+6l1nO1egxdRM1JlHroV33oRBXMFoUZUowpobGWeJubjw7WB86 39qoR4xwnyPup3+HHlKVBXmRg6j7jayOUdU0o69kJYO7M0QB/CjADePpSDTrcb9n lkk5KSYVQRzbOar7n9J6jiYoL5WFdj7uSCLpfQ5u/b26r/U2I/YGWPj/w6oGR9+v +3tp/XeRDuXUQkplQEd7
=jW2y
-----END PGP SIGNATURE-----