Skip to content

libceph: kill the "trail" portion of message data

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4libceph: have osd requests support pagelist datainclude/linux/ceph/osd_client.h net/ceph/osd_client.c+3 -10 replies
2/4libceph: kill osd request r_trailinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+0 -20 replies
3/4libceph: kill message trailinclude/linux/ceph/messenger.h net/ceph/messenger.c+0 -40 replies
4/4libceph: more cleanup of write_partial_msg_pages()net/ceph/messenger.c+0 -01 reply

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Durgin
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] libceph: kill the "trail" portion of message data

The trail portion of message data was added to support two distinct sets of data for an osd request--one a pagelist for providing parameters to object method calls; and a second a page array for receiving data back from the result of such a call.

It's always been a bit of a weird thing bolted onto a message though, and with the rework of the messenger code it can now be removed.

This series eliminates the trail by allowing the osd client to record a (non-trail) pagelist for data, and using the fact that we now distinguish incoming from outgoing data to allow that to be specified distinct from the page array used for the incoming response.

Having done this, we can eliminate the trail from the ceph message structure, and then that allows some code to be simplified.

These patches are available in the "review/wip-kill-trail" branch of the ceph-client git repository. That branch is based on branch "review/wip-cursor".

-Alex

[PATCH 1/4] libceph: have osd requests support pagelist data [PATCH 2/4] libceph: kill osd request r_trail
[PATCH 3/4] libceph: kill message trail
[PATCH 4/4] libceph: more cleanup of write_partial_msg_pages()