Skip to content

cpuacct, cgroup: Kill cgroup_subsys.active

Li Zefan cgroups lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review
  2. v15 patches 1 replySuperseded

Changes in v2 from the cover letter

- rebase against tip-tree
- add acked-by

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cpuacct: allocate per_cpu cpuusage for root cpuacct staticallykernel/sched/cpuacct.c+2 -20 replies
2/5cpuacct: Initialize root cpuacct earlierkernel/sched/core.c kernel/sched/cpuacct.c kernel/sched/cpuacct.h+4 -140 replies
3/5cpuacct: Initialize cpuacct subsystem earlierkernel/sched/cpuacct.c+6 -50 replies
4/5cpuacct: No need to check subsys active statekernel/sched/cpuacct.c+0 -60 replies
5/5cgroup: Kill subsys.active flaginclude/linux/cgroup.h kernel/cgroup.c+0 -40 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTejun HeoPeter Zijlstra
SeriesA-b
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] cpuacct, cgroup: Kill cgroup_subsys.active

v2:
- rebase against tip-tree
- add acked-by

I said this patchset needn't to be rebased, which is wrong. The last patch needs rebasing.

===================================

cpuacct is the only user of cgroup_subsys.active flag.

The flag is needed because cpuacct_charge() and cpuacct_account_field() can be called when cpuacct hasn't been initialized during system bootup.

This patch initializes cpuacct earlier, and the result is we don't have to check the flag in scheduler hot path.

Note, this patchset is based on "[PATCH v2 0/7] sched: Split cpuacct"

	http://lkml.org/lkml/2013/3/28/1

0001-cpuacct-allocate-per_cpu-cpuusage-for-root-cpuacct-s.patch 0002-cpuacct-Initialize-root-cpuacct-earlier.patch 0003-cpuacct-Initialize-cpuacct-subsystem-earlier.patch 0004-cpuacct-No-need-to-check-subsys-active-state.patch 0005-cgroup-Remove-subsys.active-flag.patch

--

 include/linux/cgroup.h |  1 -
 kernel/cgroup.c        |  3 ---
 kernel/sched/core.c    |  2 --
 kernel/sched/cpuacct.c | 30 +++++++++++-------------------
 kernel/sched/cpuacct.h |  5 -----
 5 files changed, 11 insertions(+), 30 deletions(-)