Skip to content

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ceph: use page_offset() in ceph_writepages_start()fs/ceph/addr.c+1 -10 replies
2/9libceph: drop ceph_osd_request->r_con_filling_msginclude/linux/ceph/osd_client.h net/ceph/osd_client.c+2 -90 replies
3/9libceph: record length of bio list with biodrivers/block/rbd.c include/linux/ceph/osd_client.h+5 -10 replies
4/9libceph: record message data lengthinclude/linux/ceph/messenger.h net/ceph/messenger.c net/ceph/osd_client.c+1 -01 reply
5/9libceph: don't build request in ceph_osdc_new_request()fs/ceph/addr.c fs/ceph/file.c include/linux/ceph/osd_client.h +1 more+0 -00 replies
6/9ceph: define ceph_writepages_osd_request()fs/ceph/addr.c+24 -100 replies
7/9ceph: kill ceph alloc_page_vec()fs/ceph/addr.c+0 -00 replies
8/9libceph: hold off building osd requestfs/ceph/addr.c fs/ceph/file.c net/ceph/osd_client.c+6 -50 replies
9/9ceph: build osd request message later for writepagesfs/ceph/addr.c include/linux/ceph/osd_client.h net/ceph/osd_client.c+33 -260 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Durgin
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9]

(The following patches are available in branch "review/wip-3761" on the ceph-client git respository.)

These are actually a few sets of patches but I'm just going to post them as a single series this time.

-Alex

[PATCH 1/9] ceph: use page_offset() in ceph_writepages_start()
Fixes a potential bug in ceph_writepages_start().

[PATCH 2/9] libceph: drop ceph_osd_request->r_con_filling_msg
Removes a no-longer-needed field, to simplify code.

[PATCH 3/9] libceph: record length of bio list with bio [PATCH 4/9] libceph: record message data length
Has each message maintain its data length, so we can avoid depending on what's in the message's header.

[PATCH 5/9] libceph: don't build request in ceph_osdc_new_request() [PATCH 6/9] ceph: define ceph_writepages_osd_request() [PATCH 7/9] ceph: kill ceph alloc_page_vec()
[PATCH 8/9] libceph: hold off building osd request [PATCH 9/9] ceph: build osd request message later for writepages
Defers "building" a request message until right before it's submitted to the osd client to start its execution. Also stops having the length field in a message header get updated by the file system code.