libceph: per-op osd request data
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 20 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | rbd: define inbound data size for method opsdrivers/ | +0 | 1 reply | |
| 2/20 | libceph: compute incoming bytes oncenet/ | +0 | 1 reply | |
| 3/20 | libceph: define osd data initialization helpersdrivers/ fs/ fs/ +2 more | +5 | 1 reply | |
| 4/20 | libceph: define a few more helpersnet/ | +0 | 1 reply | |
| 5/20 | libceph: define ceph_osd_data_length()net/ | +0 | 1 reply | |
| 6/20 | libceph: a few more osd data cleanupsfs/ | +0 | 1 reply | |
| 7/20 | rbd: define rbd_osd_req_format_op()drivers/ | +0 | 1 reply | |
| 8/20 | libceph: keep source rather than message osd op arraydrivers/ fs/ fs/ +3 more | +35 | 1 reply | |
| 9/20 | libceph: rename data out field in osd request opinclude/ net/ | +2 | 1 reply | |
| 10/20 | libceph: add data pointers in osd op structuresdrivers/ fs/ fs/ +2 more | +5 | 1 reply | |
| 11/20 | libceph: specify osd op by index in requestdrivers/ fs/ include/ +1 more | +13 | 1 reply | |
| 12/20 | rbd: don't set data in rbd_osd_req_format_op()drivers/ | +0 | 1 reply | |
| 13/20 | rbd: separate initialization of osd datadrivers/ | +0 | 1 reply | |
| 14/20 | rbd: rearrange some code for consistencydrivers/ | +0 | 1 reply | |
| 15/20 | libceph: format class info at init timeinclude/ net/ | +2 | 1 reply | |
| 16/20 | libceph: move ceph_osdc_build_request()net/ | +0 | 1 reply | |
| 17/20 | libceph: set message data when building osd requestnet/ | +0 | 1 reply | |
| 18/20 | libceph: combine initializing and setting osd datadrivers/ fs/ fs/ +2 more | +2 | 1 reply | |
| 19/20 | libceph: set the data pointers when encoding opsinclude/ net/ | +1 | 1 reply | |
| 20/20 | libceph: kill off osd request r_data_in and r_data_outinclude/ net/ | +3 | 1 reply |
Reviews trailers per patch
All 20 patches have a Reviewed-by or Acked-by.
| Patch | Josh Durgin |
|---|---|
| 1/20 | R-b |
| 2/20 | R-b |
| 3/20 | R-b |
| 4/20 | R-b |
| 5/20 | R-b |
| 6/20 | R-b |
| 7/20 | R-b |
| 8/20 | R-b |
| 9/20 | R-b |
| 10/20 | R-b |
| 11/20 | R-b |
| 12/20 | R-b |
| 13/20 | R-b |
| 14/20 | R-b |
| 15/20 | R-b |
| 16/20 | R-b |
| 17/20 | R-b |
| 18/20 | R-b |
| 19/20 | R-b |
| 20/20 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/20] libceph: per-op osd request data
This series of patches arranges for each op in an osd request to define its own incoming and outgoing data. Doing so allows a single request to contain muliple ops which provide outgoing data, and even allows a single op to supply more than one item of data.
A bunch of the patches here are fairly trivial cleanups, done as I was figuring out how to get things done. But in the end the changes involved are significant so I tried to do them in methodical steps.
These patches (and the one I just posted) are available in the branch "review/wip-3761-1" in the ceph-client git repository.
-Alex
[PATCH 01/20] rbd: define inbound data size for method ops
Whoops, this one's not directly related to the rest, I intended to post this one by itself.
[PATCH 02/20] libceph: compute incoming bytes once [PATCH 03/20] libceph: define osd data initialization helpers [PATCH 04/20] libceph: define a few more helpers [PATCH 05/20] libceph: define ceph_osd_data_length() [PATCH 06/20] libceph: a few more osd data cleanups
Simple cleanups, and code encapsulation.
[PATCH 07/20] rbd: define rbd_osd_req_format_op()
[PATCH 08/20] libceph: keep source rather than message osd op array
Store the source op array in the osd request structure.
[PATCH 09/20] libceph: rename data out field in osd request op [PATCH 10/20] libceph: add data pointers in osd op structures [PATCH 11/20] libceph: specify osd op by index in request
Start defining op data in the op structure itself.
[PATCH 12/20] rbd: don't set data in rbd_osd_req_format_op() [PATCH 13/20] rbd: separate initialization of osd data [PATCH 14/20] rbd: rearrange some code for consistency
Changes to rbd so it doesn't assume single op per request.
[PATCH 15/20] libceph: format class info at init time
Don't wait until formatting the op to lay out the request information (class, method, and data). Define a new data item in the CALL op structure to represent this.
[PATCH 16/20] libceph: move ceph_osdc_build_request() [PATCH 17/20] libceph: set message data when building osd request [PATCH 18/20] libceph: combine initializing and setting osd data [PATCH 19/20] libceph: set the data pointers when encoding ops [PATCH 20/20] libceph: kill off osd request r_data_in and r_data_out
These last five (four really) finally make the switch over to using data item descriptions present in the ops to dictate what's used in osd request and response messages.