Skip to content

libceph: per-op osd request data

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20rbd: define inbound data size for method opsdrivers/block/rbd.c+0 -01 reply
2/20libceph: compute incoming bytes oncenet/ceph/osd_client.c+0 -01 reply
3/20libceph: define osd data initialization helpersdrivers/block/rbd.c fs/ceph/addr.c fs/ceph/file.c +2 more+5 -91 reply
4/20libceph: define a few more helpersnet/ceph/osd_client.c+0 -01 reply
5/20libceph: define ceph_osd_data_length()net/ceph/osd_client.c+0 -01 reply
6/20libceph: a few more osd data cleanupsfs/ceph/addr.c+0 -01 reply
7/20rbd: define rbd_osd_req_format_op()drivers/block/rbd.c+0 -01 reply
8/20libceph: keep source rather than message osd op arraydrivers/block/rbd.c fs/ceph/addr.c fs/ceph/file.c +3 more+35 -341 reply
9/20libceph: rename data out field in osd request opinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+2 -21 reply
10/20libceph: add data pointers in osd op structuresdrivers/block/rbd.c fs/ceph/addr.c fs/ceph/file.c +2 more+5 -21 reply
11/20libceph: specify osd op by index in requestdrivers/block/rbd.c fs/ceph/addr.c include/linux/ceph/osd_client.h +1 more+13 -61 reply
12/20rbd: don't set data in rbd_osd_req_format_op()drivers/block/rbd.c+0 -01 reply
13/20rbd: separate initialization of osd datadrivers/block/rbd.c+0 -191 reply
14/20rbd: rearrange some code for consistencydrivers/block/rbd.c+0 -01 reply
15/20libceph: format class info at init timeinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+2 -11 reply
16/20libceph: move ceph_osdc_build_request()net/ceph/osd_client.c+0 -01 reply
17/20libceph: set message data when building osd requestnet/ceph/osd_client.c+0 -01 reply
18/20libceph: combine initializing and setting osd datadrivers/block/rbd.c fs/ceph/addr.c fs/ceph/file.c +2 more+2 -21 reply
19/20libceph: set the data pointers when encoding opsinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+1 -11 reply
20/20libceph: kill off osd request r_data_in and r_data_outinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+3 -61 reply

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchJosh Durgin
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] libceph: per-op osd request data

This series of patches arranges for each op in an osd request to define its own incoming and outgoing data. Doing so allows a single request to contain muliple ops which provide outgoing data, and even allows a single op to supply more than one item of data.

A bunch of the patches here are fairly trivial cleanups, done as I was figuring out how to get things done. But in the end the changes involved are significant so I tried to do them in methodical steps.

These patches (and the one I just posted) are available in the branch "review/wip-3761-1" in the ceph-client git repository.

-Alex

[PATCH 01/20] rbd: define inbound data size for method ops
Whoops, this one's not directly related to the rest, I intended to post this one by itself.

[PATCH 02/20] libceph: compute incoming bytes once [PATCH 03/20] libceph: define osd data initialization helpers [PATCH 04/20] libceph: define a few more helpers [PATCH 05/20] libceph: define ceph_osd_data_length() [PATCH 06/20] libceph: a few more osd data cleanups
Simple cleanups, and code encapsulation.

[PATCH 07/20] rbd: define rbd_osd_req_format_op()
[PATCH 08/20] libceph: keep source rather than message osd op array
Store the source op array in the osd request structure.

[PATCH 09/20] libceph: rename data out field in osd request op [PATCH 10/20] libceph: add data pointers in osd op structures [PATCH 11/20] libceph: specify osd op by index in request
Start defining op data in the op structure itself.

[PATCH 12/20] rbd: don't set data in rbd_osd_req_format_op() [PATCH 13/20] rbd: separate initialization of osd data [PATCH 14/20] rbd: rearrange some code for consistency
Changes to rbd so it doesn't assume single op per request.

[PATCH 15/20] libceph: format class info at init time
Don't wait until formatting the op to lay out the request information (class, method, and data). Define a new data item in the CALL op structure to represent this.

[PATCH 16/20] libceph: move ceph_osdc_build_request() [PATCH 17/20] libceph: set message data when building osd request [PATCH 18/20] libceph: combine initializing and setting osd data [PATCH 19/20] libceph: set the data pointers when encoding ops [PATCH 20/20] libceph: kill off osd request r_data_in and r_data_out
These last five (four really) finally make the switch over to using data item descriptions present in the ops to dictate what's used in osd request and response messages.