Skip to content

clk: Exynos: Register audio subsytem clocks using common clk framework

Sylwester Nawrocki linux-arm-kernel linux-devicetree linux-samsung-soc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] clk: Exynos: Register audio subsytem clocks using common clk framework

Hi,

Quoted 7 lines · Padma Venkat
Quoted 3 lines · Sylwester Nawrocki

From a brief look Exynos4 and Exynos5 Audio Subsystem CLKCON very similar. I've just found bit 2 of 0x0381_0008 register is not used on Exynos5250.

I added bit 2 as i2s_bus gate clock or you are pointing to something else?

Sorry, I should have written "bit 1".

Quoted 9 lines
Quoted 7 lines

Additionally the Audio Subsystem Clock controller is present on S5PV210 SoCs and IMO compatible property you used is too generic. I would propose to use at least:

"samsung,s5pv210-audss-clock" - for S5PV210
"samsung,exynos4210-audss-clock" - for Exynos4
"samsung,exynos5250-audss-clock" - for Exynos5

Different compatible names means different driver files for exynos4 and 5??

No, it would be same driver but with multiple entries in the of_match_table.

Quoted 5 lines

I haven't seen any difference between Exynos4 and Exynos5 audio subsystem. Can't we maintain one for both? If any extra clock instance is added on newer SoCs
anyway it gets added at the end of the list of clocks. Please correct me if I am wrong.

Sure, the differences between Exynos4 and Exynos5 audio subsystem are very minor ones. So we could easily use one clock driver for those. Probably same driver can be used for S5PV210, an any differences could be handled in the driver based on the compatible property.

Thanks,
Sylwester

Signature · 2 lines
Sylwester Nawrocki
Samsung Poland R&D Center