cpuidle: code consolidation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest15 patches 0 repliesNew
- v3 posting 2/20 of 19 patches 0 repliesSuperseded
- v3 posting 1/219 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 19 patches | 0 replies | Superseded | |
| v1 | 0 of 18 patches | 0 replies | Superseded |
Changelog from the cover letter · 27 lines
- V4:
* Added the different Acked-by and Reviewed-by
* Removed the patches already merged:
* ARM: shmobile: cpuidle: remove shmobile_enter_wfi function
* ARM: shmobile: cpuidle: remove shmobile_enter_wfi prototype
* ARM: OMAP3: remove cpuidle_wrap_enter
* Removed patch without acked-by (no answer from the maintainer)
* ARM: s3c64xx: cpuidle: use init/exit common routine
- V3:
* folded patch 5/19 into 19/19, they were:
* ARM: imx: cpuidle: use init/exit common routine
* ARM: imx: cpuidle: create separate drivers for imx5/imx6
* removed rule to make cpuidle.o in the imx's Makefile
* splitted patch 1/19 into two, they are:
* [V3 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi
* [V3 patch 02/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi prototype
- V2:
* fixed cpumask NULL test for coupled state in cpuidle_register
* added comment about structure copy
* changed printk by pr_err
* folded splitted message
* fixed return code in cpuidle_register
* updated Documentation/cpuidle/drivers.txt
* added in the changelog dev->state_count is filled by cpuidle_enable_device
* fixed tag for tegra in the first line patch description
* fixed tegra2 removed tegra_tear_down_cpu = tegra20_tear_down_cpu;
- V1: Initial post
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | cpuidle: remove en_core_tk_irqen flagarch/ arch/ arch/ +20 more | +18 | 0 replies | |
| 2/15 | ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpuarch/ | +2 | 1 reply | |
| 3/15 | cpuidle: make a single register function for allDocumentation/ drivers/ include/ | +85 | 2 replies | |
| 3/15 | cpuidle: make a single register function for alldrivers/ | +0 | 1 reply | |
| 4/15 | ARM: ux500: cpuidle: use init/exit common routinearch/ | +1 | 0 replies | |
| 5/15 | ARM: at91: cpuidle: use init/exit common routinearch/ | +2 | 0 replies | |
| 6/15 | ARM: OMAP3: cpuidle: use init/exit common routinearch/ | +2 | 0 replies | |
| 7/15 | ARM: tegra: cpuidle: use init/exit common routinearch/ | +1 | 0 replies | |
| 8/15 | ARM: shmobile: cpuidle: use init/exit common routinearch/ | +1 | 0 replies | |
| 9/15 | ARM: OMAP4: cpuidle: use init/exit common routinearch/ | +2 | 0 replies | |
| 10/15 | ARM: tegra: cpuidle: use init/exit common routine for tegra2arch/ | +1 | 0 replies | |
| 11/15 | ARM: tegra: cpuidle: use init/exit common routine for tegra3arch/ | +1 | 0 replies | |
| 12/15 | ARM: calxeda: cpuidle: use init/exit common routinedrivers/ | +1 | 0 replies | |
| 13/15 | ARM: kirkwood: cpuidle: use init/exit common routinedrivers/ | +2 | 0 replies | |
| 14/15 | ARM: davinci: cpuidle: use init/exit common routinearch/ | +1 | 0 replies | |
| 15/15 | ARM: imx: cpuidle: use init/exit common routinearch/ arch/ arch/ +3 more | +44 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Hilman | Andrew Lunn | Linus Walleij | Nicolas Ferre | Santosh Shilimkar | Stephen Warren | Simon Horman | Rob Herring | Sekhar Nori | Shawn Guo |
|---|---|---|---|---|---|---|---|---|---|---|
| Series | T-b | T-b | ||||||||
| 1/15 | A-b | |||||||||
| 2/15 | A-b | |||||||||
| 3/15 | R-b | |||||||||
| 3/15 | R-b | |||||||||
| 4/15 | A-b | |||||||||
| 5/15 | A-b | |||||||||
| 6/15 | R-b T-b | A-b | ||||||||
| 7/15 | A-b | |||||||||
| 8/15 | A-b | |||||||||
| 9/15 | R-b T-b | A-b | ||||||||
| 10/15 | A-b | |||||||||
| 11/15 | A-b | |||||||||
| 12/15 | A-b | |||||||||
| 13/15 | T-b A-b | |||||||||
| 14/15 | A-b | |||||||||
| 15/15 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.
Cover letter [V4 patch 00/15] cpuidle: code consolidation
This patchset series provide some code consolidation across the different cpuidle drivers. It contains two parts, the first one is the removal of the time keeping flag and the second one, is a common initialization routine.
All the drivers use the en_core_tk_irqen flag, which means it is not necessary to make the time computation optional. We can remove this flag and assume the cpuidle framework always manage this operation.
The cpuidle code initialization is duplicated across the different drivers in the same manner.
The repeating pattern is:
SMP:
cpuidle_register_driver(drv);
for_each_possible_cpu(cpu) {
dev = per_cpu(cpuidle_device, cpu);
cpuidle_register_device(dev);
}UP:
cpuidle_register_driver(drv);cpuidle_register_device(dev);
As on a UP machine the macro 'for_each_cpu' is a one iteration loop, using the initialization loop from SMP to UP works.
The patchset does some cleanup for different drivers in order to make the init code the same. Then it introduces a generic function:
cpuidle_register(struct cpuidle_driver *drv, struct cpumask *cpumask)
The cpumask is for the coupled idle states.
The drivers are then modified to take into account this new function and to remove the duplicated code.
The benefit is observable in the diffstat: 332 lines of code removed.
Changelog:
- V4:
* Added the different Acked-by and Reviewed-by
* Removed the patches already merged:
* ARM: shmobile: cpuidle: remove shmobile_enter_wfi function
* ARM: shmobile: cpuidle: remove shmobile_enter_wfi prototype
* ARM: OMAP3: remove cpuidle_wrap_enter
* Removed patch without acked-by (no answer from the maintainer)
* ARM: s3c64xx: cpuidle: use init/exit common routine
- V3:
* folded patch 5/19 into 19/19, they were:
* ARM: imx: cpuidle: use init/exit common routine
* ARM: imx: cpuidle: create separate drivers for imx5/imx6
* removed rule to make cpuidle.o in the imx's Makefile
* splitted patch 1/19 into two, they are:
* [V3 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi
* [V3 patch 02/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi prototype
- V2:
* fixed cpumask NULL test for coupled state in cpuidle_register
* added comment about structure copy
* changed printk by pr_err
* folded splitted message
* fixed return code in cpuidle_register
* updated Documentation/cpuidle/drivers.txt
* added in the changelog dev->state_count is filled by cpuidle_enable_device
* fixed tag for tegra in the first line patch description
* fixed tegra2 removed tegra_tear_down_cpu = tegra20_tear_down_cpu;
- V1: Initial post
Tested-on: u8500
Tested-on: at91
Tested-on: intel i5
Tested-on: OMAP4
Compiled with and without CPU_IDLE for:
u8500, at91, davinci, exynos, imx5, imx6, kirkwood, multi_v7 (for calxeda), omap2plus, s3c64, tegra1, tegra2, tegra3
Daniel Lezcano (15):
cpuidle: remove en_core_tk_irqen flag
ARM: ux500: cpuidle: replace for_each_online_cpu by
for_each_possible_cpu
cpuidle: make a single register function for all
ARM: ux500: cpuidle: use init/exit common routine
ARM: at91: cpuidle: use init/exit common routine
ARM: OMAP3: cpuidle: use init/exit common routine
ARM: tegra: cpuidle: use init/exit common routine
ARM: shmobile: cpuidle: use init/exit common routine
ARM: OMAP4: cpuidle: use init/exit common routine
ARM: tegra: cpuidle: use init/exit common routine for tegra2
ARM: tegra: cpuidle: use init/exit common routine for tegra3
ARM: calxeda: cpuidle: use init/exit common routine
ARM: kirkwood: cpuidle: use init/exit common routine
ARM: davinci: cpuidle: use init/exit common routine
ARM: imx: cpuidle: use init/exit common routine
Documentation/cpuidle/driver.txt | 6 + arch/arm/mach-at91/cpuidle.c | 18 +-- arch/arm/mach-davinci/cpuidle.c | 21 +--- arch/arm/mach-exynos/cpuidle.c | 1 - arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/cpuidle-imx5.c | 37 ++++++ arch/arm/mach-imx/cpuidle-imx6q.c | 3 +- arch/arm/mach-imx/cpuidle.c | 80 ------------- arch/arm/mach-imx/cpuidle.h | 10 +- arch/arm/mach-imx/pm-imx5.c | 30 +---- arch/arm/mach-omap2/cpuidle34xx.c | 23 +--- arch/arm/mach-omap2/cpuidle44xx.c | 27 +---- arch/arm/mach-s3c64xx/cpuidle.c | 1 - arch/arm/mach-shmobile/cpuidle.c | 11 +- arch/arm/mach-shmobile/pm-sh7372.c | 1 - arch/arm/mach-tegra/cpuidle-tegra114.c | 27 +---- arch/arm/mach-tegra/cpuidle-tegra20.c | 31 +---- arch/arm/mach-tegra/cpuidle-tegra30.c | 28 +---- arch/arm/mach-ux500/cpuidle.c | 33 +----- arch/powerpc/platforms/pseries/processor_idle.c | 1 - arch/sh/kernel/cpu/shmobile/cpuidle.c | 1 - arch/x86/kernel/apm_32.c | 1 - drivers/acpi/processor_idle.c | 1 - drivers/cpuidle/cpuidle-calxeda.c | 53 +-------- drivers/cpuidle/cpuidle-kirkwood.c | 18 +-- drivers/cpuidle/cpuidle.c | 144 ++++++++++++++--------- drivers/idle/intel_idle.c | 1 - include/linux/cpuidle.h | 20 ++-- 28 files changed, 162 insertions(+), 468 deletions(-) create mode 100644 arch/arm/mach-imx/cpuidle-imx5.c delete mode 100644 arch/arm/mach-imx/cpuidle.c
Signature · 1 line
1.7.9.5