Another round of ARMv7-M patches
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest posting 2/20 of 3 patches 0 repliesNew
- v11 posting 1/20 of 3 patches 0 repliesSuperseded
Patches in v11 posting 2/2 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v11 yet.
Cover letter [PATCH v11 0/3] Another round of ARMv7-M patches
Hi,
Quoted 6 lines · Uwe Kleine-K?nig
Hello,
Quoted 2 lines · Jonathan Austin
The only comment I have left is that I'd really like the
BASEADDRESS_V7M_SCBnamespaced like the rest of the V7M definesThe idea behind this naming is that
V7M_SCB_BASEADDRESSis in the same
Do you mean is *not* in?
Quoted 2 lines
namespace as
V7M_SCB_CPUIDso I opened a new namespace for base addresses. Don't you like it only because it's new?
I think becausereadl(V7M_SCB_BASEADDRESS + V7M_SCB_CPUID)
reads more cleanly than
readl(BASEADDRESS_V7M_SCB + V7M_SCB_CPUID)
But it isn't a big enough issue to delay merging these - more a preference/style issue. As you ask: does anyone else have any thoughts?
Jonny
Quoted 10 lines
Do others have
thoughts here?Quoted 4 lines
With that said, please feel free to add for the series:
Reviewed-by Jonathan Austin <[email protected]>Tested-by Jonathan Austin <[email protected]Thanks
Uwe