btrfs-progs: standardize utility filenames and add default rules to Makefile
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs-progs: standardize tool source filenamesMakefile btrfs-calc-size.c btrfs-convert.c +3 more | +13 | 1 reply | |
| 2/2 | btrfs-progs: Add default rules to MakefileMakefile | +26 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] btrfs-progs: standardize utility filenames and add default rules to Makefile
2 patches here.
The first renames the single .c files which are built into btrfs-$FOO commands - previously we built i.e. btrfs-calc-size from calc-size.c
IMHO this helps separate out which files are main command-type files, and which are not. (Eventually I hope to move things into subdirs to organize a bit more).
Then, after renaming i.e. calc-size.c to btrfs-calc-size.c we can write a simpler default rule for these utilities (patch 2/2).
The default static rule is handy because it'll automatically build i.e. "make btrfs-image.static" or "make btrfs-calc-size.static" if you need them.
I think this is a net win, with a bit less Makefile code duplication, but if people don't like it, no big deal. I was hoping to clean up & re-organize the userspace build a little, and this seems like a decent first step along the way.
Comments welcome, especially from people who are better at Make than I am. ;) And if this is two clever by half I'm not wedded to it.
-Eric