Skip to content

rbd: cleanup and plug leaks

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6rbd: fix leak of snapshots during initial probedrivers/block/rbd.c+0 -01 reply
2/6rbd: make snap_size order parameter optionaldrivers/block/rbd.c+0 -01 reply
3/6rbd: only update values on snap_info successdrivers/block/rbd.c+0 -01 reply
4/6rbd: rename __rbd_add_snap_dev()drivers/block/rbd.c+0 -01 reply
5/6rbd: fix leak of format 2 snapshot namesdrivers/block/rbd.c+0 -03 replies
6/6rbd: use rbd_obj_method_sync() return valuedrivers/block/rbd.c+2 -11 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJosh Durgin
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] rbd: cleanup and plug leaks

(This series, and the patch I just posted, are available in the "review/wip-rbd-cleanup" branch of the ceph-client git repository.)

This series is one of several I expect to be posting that are mostly small tweaks and polish to the rbd code. I'm doing a review of the whole thing with an eye toward verifying error paths and finding memory leaks. Along the way I'm making small changes to improve overall consistency and perhaps shore up some coding style issues.

-Alex

[PATCH 1/6] rbd: fix leak of snapshots during initial probe [PATCH 2/6] rbd: make snap_size order parameter optional [PATCH 3/6] rbd: only update values on snap_info success [PATCH 4/6] rbd: rename __rbd_add_snap_dev() [PATCH 5/6] rbd: fix leak of format 2 snapshot names [PATCH 6/6] rbd: use rbd_obj_method_sync() return value