Skip to content

rbd: avoid snapshot update race

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rbd: move more initialization into rbd_dev_probe_image()drivers/block/rbd.c+0 -00 replies
2/5rbd: define rbd_header_name()drivers/block/rbd.c+0 -120 replies
3/5rbd: don't clean up watch in device release functiondrivers/block/rbd.c+0 -00 replies
4/5rbd: don't bother checking whether order changesdrivers/block/rbd.c+0 -00 replies
5/5rbd: set up watch in rbd_dev_probe_image()drivers/block/rbd.c+0 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Durgin
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] rbd: avoid snapshot update race

This series ends with a patch that avoids a race involving the initial read of an rbd image header and a change to the snapshot context. The problem occurs because the rbd client sets up its watch request on the header object *after* the initial header read, and if the snapshot context changes between them the kernel client snapshot context will not be up-to-date.

The fix is to set up the watch before doing the initial header read. The recent patches, along with the patches in this series, make doing things in this order possible.

-Alex

[PATCH 1/5] rbd: move more initialization into rbd_dev_probe_image() [PATCH 2/5] rbd: define rbd_header_name()
[PATCH 3/5] rbd: don't clean up watch in device release function [PATCH 4/5] rbd: don't bother checking whether order changes [PATCH 5/5] rbd: set up watch in rbd_dev_probe_image()