Skip to content

rbd: get rid of the snapshot list

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4rbd: look up snapshot name in names bufferdrivers/block/rbd.c+3 -00 replies
2/4rbd: use snap_id not index to look up snap infodrivers/block/rbd.c+0 -00 replies
3/4rbd: define rbd_snap_size() and rbd_snap_features()drivers/block/rbd.c+3 -00 replies
4/4rbd: kill off the snapshot listdrivers/block/rbd.c+0 -140 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Durgin
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] rbd: get rid of the snapshot list

An rbd device structure maintains a list of snapshot structures whose purpose is to cache the name, size, and features associated with a snapshot id. The main reason it was needed was related to the presence of Linux device information for snapshots, which we no longer have. We can look up the name, etc. "on the fly" about as easily as we can using the list, and getting rid of this list means we can eliminate a substantial bit of code.

The final patch in this series gets rid of the snapshot list and the rbd_snap structure. The first three put in place replacement functionality that doesn't require the list.

-Alex

[PATCH 1/4] rbd: look up snapshot name in names buffer [PATCH 2/4] rbd: use snap_id not index to look up snap info [PATCH 3/4] rbd: define rbd_snap_size() and rbd_snap_features() [PATCH 4/4] rbd: kill off the snapshot list