Skip to content

tcl rework (was: make usb_modeswitch work with udev)

Richard Genoud buildroot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v16 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- drop the change of BR2_PACKAGE_TCL_SHLIB_ONLY option as commit d3e4db4 (usb_modeswitch: bump to version 1.2.6) already fixes the problem.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tcl: use make conditionspackage/tcl/tcl.mk+14 -70 replies
2/5tcl: remove strip commandpackage/tcl/tcl.mk+0 -50 replies
3/5tcl: install the libtcl into stagingpackage/tcl/tcl.mk+1 -00 replies
4/5tcl: add a tclsh symlinkpackage/tcl/tcl.mk+5 -00 replies
5/5tcl: make the libtcl writable in order to be strippedpackage/tcl/tcl.mk+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [PATCHv3 0/5] tcl rework (was: make usb_modeswitch work with udev)

At first, the goal of this patch set was to add a symlink tclsh->tclsh8.4 to make usb_modeswitch_dispatcher happy (it has a shebang #!/usr/bin/tclsh).

While doing that, I saw some other problems (libtcl not stripped and not into staging). Also, Thomas suggested (and coded it actually !) that make condition should be used.
Hence, a bigger patchset.

Changes since v2:
- drop the change of BR2_PACKAGE_TCL_SHLIB_ONLY option as commit d3e4db4 (usb_modeswitch: bump to version 1.2.6) already fixes the problem.

Changes since v1:
- drop usb_modeswitch{,_data} version bumps patches as they are already mainlined (thanks Gustavo for the heads up !)
- use make conditions rather than shell conditions
- drop the explicit strip
- install the library into stating
- make the library writable

Richard Genoud (5):
tcl: use make conditions
tcl: remove strip command
tcl: install the libtcl into staging
tcl: add a tclsh symlink
tcl: make the libtcl writable in order to be stripped

 package/tcl/tcl.mk |   33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)
Signature · 1 line
1.7.10.4