Skip to content

RFC New board-specific USB initialization interface

Mateusz Zalega u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 of 10 patches 0 repliesNew

1 of 10 patches is in this archive. The cover letter announces 10.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10New board-specific USB initialization interface+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [RFC 00/10] New board-specific USB initialization interface
Quoted 18 lines · Wolfgang Denk
Quoted 12 lines

Dear Mateusz Zalega,

Quoted 8 lines · In message <[email protected]> you wrote:

Current implementation of do_dfu() and do_usb_mass_storage() requires board-specific board_usb_init() which performs USB hardware initialization.

I noticed that several boards have such a function defined, named either usb_board_init() (which binds to ohci-hcd.c driver and had been used solely by it) or board_usb_init() (as in ehci-omap.c). I _assumed_ that these functions do what's required by do_*() and renamed the earlier in order to unify the naming convention.

Quoted 4 lines

I appreciate your efforts, but this whole area clearly falls into the domain of the device model rework. Is your suggested implementation in any way synchronized with what has been discussed about this topic before?

Quoted 5 lines

I've caught up with driver model discussion. The changes I submitted are related to sharing of board-specific hardware initialization functions between drivers, therefore my patches, if I don't miss anything, do not collide with driver model rework - these changes would have to be done anyway.

If new USB driver model would use some other API to deal with board-specific functions, please correct me. I didn't manage to find related information, maybe I didn't look for it carefully enough.

Signature · 2 lines
Mateusz Zalega
Samsung R&D Institute Poland (SRPOL) | Kernel and System Framework group