Fix for top-level parallel make part 1
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/23 patches 0 repliesNew
- v2 posting 1/20 of 3 patches 0 repliesSuperseded
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | package/Makefile.in: add a way to don't force jobs in sub-make | +0 | 0 replies | |
| 2/3 | package: fix generic extract target for top-level parallel make | +0 | 4 replies | |
| 2/3 | package: fix generic extract target for top-level parallel make | +0 | 2 replies | |
| 2/3 | package: fix generic extract target for top-level parallel make | +0 | 1 reply |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| 1/3 | A-b |
| 2/3 | |
| 2/3 | |
| 2/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH v2 0/3] Fix for top-level parallel make part 1
Quoted 25 lines · Fabio Porcedda
Quoted 7 lines · Arnout Vandecappelle
Quoted 4 lines · Thomas Petazzoni
I'd really like to see top-level parallel build in Buildroot, but I don't think we should do it at the expense of build reproducibility and increase of users support complexity.
Quoted 9 lines
That said, I would say that any patch that improves the top-level parallel
build situation should be accepted, unless it really adds complexity. So 1/3 would definitely be acceptable IMHO.I also think that 2/3 and 3/3 clarify the generic infrastructure, so I'd
accept them as well. Only, they also changes the behaviour when you touch a .stamp file, so it requires a bit more thinking.Hi Arnout,
thanks for reviewing.I obviously approve the idea of accepting patches that improve top-level parallel make and does not add complexity, such as these patches.
Quoted 5 lines
You are right that 2/3 and 3/3 change the behaviour when you touch .stamp file, but i think that the touching of .stamp file for the -extract and -patch targets does not happen using buildroot targets, the touching of those .stamp files can happen only manually, so IMHO it's not a real problem.
Ah that's right, the order changed a while ago and now the -depends
come after -patch. It used to be different though.
So I guess that 2/3 and 3/3 should be acceptable as well. After a bit
of testing and a formal Ack, of course.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F