Skip to content

TWL6030, TWL6032 GPADC driver

Jonathan Cameron linux-arm-kernel linux-iio linux-omap lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest posting 2/20 of 2 patches 1 replyIn review
  2. v8 posting 1/20 of 2 patches 0 repliesSuperseded

Patches in v8 posting 2/2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/2] TWL6030, TWL6032 GPADC driver
Quoted 16 lines · Mark Rutland
Quoted 11 lines · Jonathan Cameron
Quoted 6 lines
Quoted 3 lines

The changes to the original driver:
- device tree adaptation;

I couldn't see a binding document in this series or in mainline. Have I looked in the wrong places?

Nothing explicit supplied, but does it need one given it is doing only iio bindings (bindings/iio/iio-bindings.txt)
plus twl child bindings
(bindings/mfd/twl-family.txt)

Every binding needs to be documented.

Quoted 1 line
Quoted 8 lines
Quoted 3 lines

If it does, I guess absolutely everything does, then fair enough! I guess that would make sense as there is no way for someone writing a device tree to know that there is nothing else to be specified.

Yup, that's why. Also, Linux isn't necessarily the only consumer, and other consumers shouldn't need to read Linux code to figure out how a particular binding is supposed to look.

Fair enough. Thanks for clearing that up.

Oleksandr, could you send a follow up patch adding the required documentation? (mostly a cut and paste job from similar elements by the look of it).

Thanks

Jonathan

Quoted 3 lines

Cheers,
Mark.