Skip to content

audit: fix soft lockups and udevd errors when audit is overrun

Chuck Anderson lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2audit: fix soft lockups due to loop in audit_log_start() wh,en audit_backlog_limit exceededkernel/audit.c+3 -11 reply
2/2audit: Two efficiency fixes for audit mechanismkernel/audit.c+2 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDave Kleikamp
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] audit: fix soft lockups and udevd errors when audit is overrun

The two patches that follow in separate emails resolve soft lockups and udevd reported errors that prevented a large memory 3.8 system from booting.

The patches are based on 3.11-rc7.

I believe it is the same issue recently posted as:

[RFC] audit: avoid soft lockup in audit_log_start()
https://lkml.org/lkml/2013/8/28/626

The first patch:

audit: fix soft lockups due to loop in audit_log_start() when
audit_backlog_limit exceeded

fixes a bug in kernel/audit that caused many soft lockups during boot:

  BUG: soft lockup - CPU#66 stuck for 22s! [udevd:9559]
  RIP: 0010:[<ffffffff810d1d06>]  [<ffffffff810d1d06>] 
audit_log_start+0xe6/0x350
  Call Trace:
   [<ffffffff8108ea30>] ? try_to_wake_up+0x2d0/0x2d0
   [<ffffffff810d8d6f>] audit_log_exit+0x3f/0x590
   [<ffffffff810d975d>] __audit_syscall_exit+0x28d/0x2c0
   [<ffffffff815e0440>] sysret_audit+0x17/0x21

The second patch:

audit: Two efficiency fixes for audit mechanism

prevents these and similar error messages repeated often during boot:

udevd[876]: worker [887] unexpectedly returned with status 0x0100 udevd[876]: worker [887] failed while handling
'/devices/pci0000:00/0000:00:03.0/0000:40:00.0'
udevd[876]: worker [880] unexpectedly returned with status 0x0100 udevd[876]: worker [880] failed while handling
'/devices/LNXSYSTM:00/LNXPWRBN:00/input/input1/event1'

udevadm settle - timeout of 180 seconds reached, the event queue
contains:

    /sys/devices/LNXSYSTM:00/LNXPWRBN:00/input/input1/event1 (3995)
    /sys/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/INT3F0D:00 (4034)

audit: audit_backlog=258 > audit_backlog_limit=256
audit: audit_lost=1 audit_rate_limit=0 audit_backlog_limit=256