Skip to content

Consolidate ARM timer code

Rob Herring u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/9] Consolidate ARM timer code
Quoted 17 lines · Wolfgang Denk

Dear Rob Herring,

Quoted 5 lines · In message <[email protected]> you wrote:

From: Rob Herring <[email protected]>

Much of the ARM timer code is re-implemented for each platform yet it is all pretty much the same code.

Quoted 8 lines

This series introduces a common implementation of timer functions and simplifies the platform code down to 2 or 3 config defines. It is intended for platforms with 32-bit freerunning timers. I've converted a couple of platforms as an example, but there are many more still that can be converted. This probably could be extended to work with 16-bit timers as well.

I've compiled all ARM boards, but only tested on highbank.

Quoted 7 lines

Why do we need any ARM specific code at all? What's the difference between an ARM and - say - a PowerPC system in this respect, and why do we need different code for both?

If we consolidate code, it should always be done in a cross-platform way, unless platform specifc code really cannot be avoided (which I fail to see yet here).

I agree, but it appeared that at least some PPC platforms implement timers differently using a timer interrupt. I haven't really looked at other architectures. At least moving the code to a common spot is trivial. Aside from the location, do you have any comments on the implementation?

Rob