Skip to content

Add device tree support for VxWorks

Tom Rini u-boot 3 versions – New

Get series with b4
b4 am 20131101122315.GX19303@bill-the-cat

Versions newest first · linked by author and title

  1. v2 Latest posting 3/30 of 5 patches 0 repliesNew
  2. v2 posting 2/30 of 5 patches 0 repliesSuperseded
  3. v2 posting 1/30 of 5 patches 0 repliesSuperseded

Patches in v2 posting 3/3 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/5] Add device tree support for VxWorks
Quoted 33 lines · myan

Hi Tom,

Quoted 8 lines · Tom Rini

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · myan
Quoted 1 line

Will this go into master in this merge window ?

Quoted 8 lines
Quoted 3 lines

And I noticed there are some changes to common do_bootm, which reqiures adjustment to vxworks subcommand handling code, do I need to rebase and resend the patches ? Thanks.

Yes, it can come in, I just have been a bit busy and getting behind on collecting up patches. If you can re-base and re-test things I'd appreciate it, thanks!

I re-tested against master but found a problem. In commit "5c427e4: use BOOTM_STATE_OS_CMDLINE flag for plain bootm" and "3d187b3: Only pass BOOTM_STATE_OS_CMDLINE on PowerPC/MIPS", BOOTM_STATE_OS_CMLINE was added to do_bootm for PowerPC and MIPS. This breaks other OSes (vxworks, netbsd, plan9,...) that don't support subcommand processing, e.g. they all contain the following code in their do_bootm_xxx():

if (flag & BOOTM_STATE_OS_PREP)

	return 0;
if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
	return 1;
Quoted 8 lines

which will result a "subcommand not supported" error. IMO, the
above code should be converted to something like this:

/* if not go command, pretend everything to be OK */ if (flag != BOOTM_STATE_OS_GO)

    return 0;

And if you are OK with it, I could send patches to clean them up. Thanks.

OK, reading over all of the other OS bootm functions, yeah, I think you're on the right path here. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131101/a7db62a8/attachment.pgp>